MAINT: flake8 *.pyx files #14147
MAINT: flake8 *.pyx files #14147
Conversation
Current coverage is 85.26% (diff: 100%)
|
|
not sure what u mean E226 is not universally accepted pls turn it back on |
|
ok, forget about E226, its not so easy to remove. can you add E128 back to the |
| do | ||
| echo "linting -> pandas/$path" | ||
| flake8 pandas/$path --filename '*.pyx' --select=E501,E302,E203,E226,E111,E114,E221,E303,E128,E231,E126 | ||
| flake8 pandas/$path --filename '*.pyx' --select=E501,E302,E203,E111,E114,E221,E303,E128,E231,E126 |
There was a problem hiding this comment.
change this to not use a loop, IOW flake8 pandas --filename '*.pyx' --select=..... will catch all .pyx (even if we add/move them)
|
@jreback : I'm actually surprised that all of these |
|
no this needs fixing here as u edited the .pyx for algos and join which are auto generated and will revert when the pxi.in are changed |
|
@jreback : Ah, fair enough. Will fix then. |
flake8-ed *.pyx files and fixed errors. Removed the E226 check because that inhibits pointers (e.g. char*). In addition, the check is not even universally accepted in Python.
|
@jreback : On second look, what do you mean that |
|
right the .pxi are included at cythonization time |
|
@jreback : Nice! You got Appveyor to work and now block this PR 😄 😠 At least Appveyor is not failing because of my PR. Need to fix that 3.5 failure with the locale. |
|
oh that's great! and I stole from numpy a line in appveyor.yml |
|
thanks! |
closes #12995
flake8-ed *.pyx files and fixed errors.
Removed the E226 check because that inhibits pointers (e.g. char*). In addition, the check is not even universally accepted in Python.