Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP: fix up *.pyx #12995

Closed
jreback opened this issue Apr 26, 2016 · 1 comment
Closed

PEP: fix up *.pyx #12995

jreback opened this issue Apr 26, 2016 · 1 comment
Labels
Code Style Code style, linting, code_checks
Milestone
0.19.0

Comments

@jreback
Copy link
Contributor

jreback commented Apr 26, 2016

we don't by default check the .pyx files, we should. So this issue will cover fixing & updating the setup.cfg, need to add: filename: *.py, *.pyx
@jreback jreback added Difficulty Novice Code Style Code style, linting, code_checks labels Apr 26, 2016
@jreback jreback added this to the 0.18.2 milestone Apr 26, 2016
@jreback jreback mentioned this issue Apr 26, 2016
Closed
@jreback
Copy link
Contributor Author

jreback commented Jun 8, 2016

flake8 windows.pyx --select=E501,E302,E203,E226,E111,E114,E221,E303,E128,E231,E126,E128

seems to catch whitespace things and not bork on some cython specific pep things.

am going to include a filter for this in a future PR.

@takuti takuti mentioned this issue Jun 16, 2016
Merged
jreback added a commit to jreback/pandas that referenced this issue Jun 25, 2016
@jreback
ENH: add time-window capability to .rolling
05331e8 
xref pandas-dev#13327
CLN: pep for cython, xref pandas-dev#12995
@jreback jreback mentioned this issue Jun 26, 2016
Closed
@jreback jreback modified the milestones: 0.19.0, 0.18.2 Jun 26, 2016
jreback added a commit to jreback/pandas that referenced this issue Jul 1, 2016
@jreback
ENH: add time-window capability to .rolling
906740e 
xref pandas-dev#13327
CLN: pep for cython, xref pandas-dev#12995
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.20.0, 0.19.0 Jul 8, 2016
jreback added a commit to jreback/pandas that referenced this issue Jul 14, 2016
@jreback
ENH: add time-window capability to .rolling
d8f3d73 
xref pandas-dev#13327
CLN: pep for cython, xref pandas-dev#12995
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.20.0, 0.19.0 Aug 15, 2016
@gfyoung gfyoung mentioned this issue Sep 4, 2016
Closed
@jreback jreback modified the milestones: 0.19.0, 0.20.0 Sep 4, 2016
@jreback jreback closed this as completed in e54d4db Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
0.19.0
Development

Successfully merging a pull request may close this issue.

MAINT: flake8 *.pyx files forking-repos/pandas
2 participants
@jreback @jorisvandenbossche