Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo #15844

Merged
merged 1 commit into from
Mar 30, 2017
Merged

Fix a typo #15844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/sparse/sparse.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ cdef class IntIndex(SparseIndex):
def check_integrity(self):
"""
Only need be strictly ascending and nothing less than 0 or greater than
totall ength
total length
"""
pass
Copy link
Member

@gfyoung gfyoung Mar 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crayxt : Thanks for patching this! Seems though that there might be bigger questions beyond just a simple typo fix (for better or worse) 😄

Though FYI, given how trivial the change is, you can also add [ci skip] to messages of commits like these to avoid triggering builds that should most certainly pass.

@jreback : Is there any reason that this is implemented (not required from super-class)?

I don't see it used anywhere by IntIndex, and the implementation is just pass even though the documentation (grammar error notwithstanding) says it should do something.

If it is supposed to be used, should we move this method to the SparseIndex class (common method among the two sub-classes in that file)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah looks like was for a possible impl. Certainly could refactor if you'd like.


Expand Down