Fix a typo #15844
Fix a typo #15844
Conversation
| @@ -71,7 +71,7 @@ cdef class IntIndex(SparseIndex): | |||
| def check_integrity(self): | |||
| """ | |||
| Only need be strictly ascending and nothing less than 0 or greater than | |||
| totall ength | |||
| total length | |||
| """ | |||
| pass | |||
There was a problem hiding this comment.
@crayxt : Thanks for patching this! Seems though that there might be bigger questions beyond just a simple typo fix (for better or worse) 😄
Though FYI, given how trivial the change is, you can also add [ci skip] to messages of commits like these to avoid triggering builds that should most certainly pass.
@jreback : Is there any reason that this is implemented (not required from super-class)?
I don't see it used anywhere by IntIndex, and the implementation is just pass even though the documentation (grammar error notwithstanding) says it should do something.
If it is supposed to be used, should we move this method to the SparseIndex class (common method among the two sub-classes in that file)?
There was a problem hiding this comment.
yeah looks like was for a possible impl. Certainly could refactor if you'd like.
Codecov Report
@@ Coverage Diff @@
## master #15844 +/- ##
==========================================
- Coverage 90.97% 90.96% -0.02%
==========================================
Files 143 143
Lines 49442 49442
==========================================
- Hits 44982 44973 -9
- Misses 4460 4469 +9
Continue to review full report at Codecov.
|
|
thanks @crayxt |
The check_integrity method of IntIndex in pandas.sparse was un- implemented despite having documentation. This PR implements the method and calls it when initializing `IntIndex`. xref <a href="https://github.com/pandas- dev/pandas/pull/15844#discussion_r108840154">#15844 (comment)</a> Author: gfyoung <gfyoung17@gmail.com> Closes #15863 from gfyoung/sparse-pyx-refactor and squashes the following commits: f435d28 [gfyoung] BUG: Check integrity of sparse int indices
Fixes a small typo.