Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Check integrity of sparse int indices #15863

Closed
wants to merge 1 commit into from

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Apr 2, 2017

The check_integrity method of IntIndex in pandas.sparse was un-implemented despite having documentation. This PR implements the method and calls it when initializing IntIndex.

xref #15844 (comment)

@gfyoung gfyoung force-pushed the sparse-pyx-refactor branch 2 times, most recently from 5b9da45 to c6e3e9c Compare April 2, 2017 03:39
@gfyoung gfyoung force-pushed the sparse-pyx-refactor branch from c6e3e9c to f435d28 Compare April 2, 2017 04:13
@codecov
Copy link

codecov bot commented Apr 2, 2017

Codecov Report

Merging #15863 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15863      +/-   ##
==========================================
- Coverage   90.98%   90.96%   -0.03%     
==========================================
  Files         143      143              
  Lines       49449    49449              
==========================================
- Hits        44993    44983      -10     
- Misses       4456     4466      +10
Flag Coverage Δ
#multiple 88.72% <ø> (-0.01%) ⬇️
#single 40.65% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/common.py 90.96% <0%> (-0.34%) ⬇️
pandas/core/frame.py 97.56% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e1ba0...f435d28. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 2, 2017

Codecov Report

Merging #15863 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15863      +/-   ##
==========================================
- Coverage   90.98%   90.96%   -0.03%     
==========================================
  Files         143      143              
  Lines       49449    49449              
==========================================
- Hits        44993    44983      -10     
- Misses       4456     4466      +10
Flag Coverage Δ
#multiple 88.72% <ø> (-0.01%) ⬇️
#single 40.65% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.56% <0%> (-0.1%) ⬇️
pandas/tseries/index.py 95.33% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e1ba0...f435d28. Read the comment docs.

@jreback jreback added the Sparse Sparse Data Type label Apr 2, 2017
@jreback jreback added this to the 0.20.0 milestone Apr 2, 2017
@jreback
Copy link
Contributor

jreback commented Apr 2, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sparse Sparse Data Type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants