Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Remove __init__ statements in testing #16238

Merged
merged 1 commit into from
May 4, 2017

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented May 4, 2017

We should never have had __init__ in a test case (even with the old nose paradigm).

Closes #16235.

@codecov
Copy link

codecov bot commented May 4, 2017

Codecov Report

Merging #16238 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16238      +/-   ##
==========================================
+ Coverage   90.24%   90.34%   +0.09%     
==========================================
  Files         164      164              
  Lines       50894    50894              
==========================================
+ Hits        45930    45979      +49     
+ Misses       4964     4915      -49
Flag Coverage Δ
#multiple 88.12% <ø> (+0.11%) ⬆️
#single 40.3% <ø> (-0.1%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/common.py 90.68% <0%> (-0.35%) ⬇️
pandas/core/frame.py 97.58% <0%> (-0.1%) ⬇️
pandas/_version.py 44.65% <0%> (+1.9%) ⬆️
pandas/core/config.py 88.09% <0%> (+18.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2002da3...35cfd34. Read the comment docs.

@codecov
Copy link

codecov bot commented May 4, 2017

Codecov Report

Merging #16238 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16238      +/-   ##
==========================================
+ Coverage   90.24%   90.34%   +0.09%     
==========================================
  Files         164      164              
  Lines       50894    50894              
==========================================
+ Hits        45930    45979      +49     
+ Misses       4964     4915      -49
Flag Coverage Δ
#multiple 88.12% <ø> (+0.11%) ⬆️
#single 40.3% <ø> (-0.1%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/common.py 90.68% <0%> (-0.35%) ⬇️
pandas/core/frame.py 97.58% <0%> (-0.1%) ⬇️
pandas/_version.py 44.65% <0%> (+1.9%) ⬆️
pandas/core/config.py 88.09% <0%> (+18.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2002da3...35cfd34. Read the comment docs.

@jreback jreback added the Testing pandas testing functions or related to the test suite label May 4, 2017
@jreback jreback added this to the 0.20.0 milestone May 4, 2017
@jreback jreback merged commit a54efdd into pandas-dev:master May 4, 2017
@jreback
Copy link
Contributor

jreback commented May 4, 2017

thanks!

@gfyoung gfyoung deleted the test-case-init-warning branch May 4, 2017 21:29
pcluo pushed a commit to pcluo/pandas that referenced this pull request May 22, 2017
stangirala pushed a commit to stangirala/pandas that referenced this pull request Jun 11, 2017
yarikoptic added a commit to neurodebian/pandas that referenced this pull request Jul 12, 2017
Version 0.20.0

* tag 'v0.20.0': (742 commits)
  RLS: v0.20.0
  DOC: Whatsnew cleanup (pandas-dev#16245)
  TST: Test CategoricalIndex in test_is_categorical (pandas-dev#16243)
  TST: xfail some bottleneck on windows (pandas-dev#16240)
  DOC, TST: Document and Test Functions in dtypes/common.py (pandas-dev#16237)
  TST: Remove __init__ statements in testing (pandas-dev#16238)
  DOC: don't include all methods/attributes of IntervalIndex (pandas-dev#16221)
  PKG: Fix ModuleNotFoundError: No module named 'pandas.formats' (pandas-dev#16239)
  RLS: v0.20.0rc2
  CLN: make submodules of pandas.util private (pandas-dev#16223)
  MAINT: Remove tm.TestCase from testing (pandas-dev#16225)
  MAINT: Complete Conversion to Pytest Idiom (pandas-dev#16201)
  DOC: add whatsnew for 0.21.0
  DEPR: correct deprecation message for datetools (pandas-dev#16202)
  API Change repr name for table schema (pandas-dev#16204)
  DOC: Remove various warnings from doc build (pandas-dev#16206)
  DOC: add whatsnew for v0.20.1
  BUG: Fixed renaming of falsey names in build_table_schema (pandas-dev#16205)
  COMPAT: ensure proper extension dtype's don't pickle the cache (pandas-dev#16207)
  REF: register custom DisplayFormatter for table schema (pandas-dev#16198)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants