CLN: make submodules of pandas.util private #16223

jreback · 2017-05-04T02:15:03Z

jorisvandenbossche

Looks good!

jorisvandenbossche · 2017-05-04T07:44:12Z

doc/source/whatsnew/v0.20.0.txt

    "pandas._period", "pandas._libs.period", ""
    "pandas._sparse", "pandas.core.sparse.libsparse", ""
-    "pandas._testing", "pandas.util.libtesting", ""
+    "pandas._testing", "pandas.util._testing", ""


Is there a specific reason we do not put this in _libs ?

jorisvandenbossche · 2017-05-04T07:45:15Z

doc/source/whatsnew/v0.20.0.txt

@@ -1254,6 +1254,8 @@ these are now the public subpackages.

 - The function :func:`~pandas.api.types.union_categoricals` is now importable from ``pandas.api.types``, formerly from ``pandas.types.concat`` (:issue:`15998`)
 - The type import ``pandas.tslib.NaTType`` is deprecated and can be replaced by using ``type(pandas.NaT)`` (:issue:`16146`)
+- The public functions in ``pandas.util.hashing`` deprecated from that locations, but are now importable from ``pandas.util`` (:issue:`16223`)


This is not needed (the util.hashing module is new, not yet released), but you might need to update the entry about the move from tools.hashing to utils.hashing

jorisvandenbossche · 2017-05-04T08:03:41Z

pandas/util/hashing.py

+            warnings.warn("pandas.util.hashing is deprecated and will be "
+                          "removed in a future version, import "
+                          "from pandas.util",
+                          FutureWarning, stacklevel=3)


This is not needed I think, as I said above, see my recent PR here: https://github.com/pandas-dev/pandas/pull/16086/files, this was moved from pandas.tools to util.

jorisvandenbossche · 2017-05-04T08:07:02Z

asv_bench/benchmarks/attrs_caching.py

@@ -1,5 +1,5 @@
 from .pandas_vb_common import *
-from pandas.util.decorators import cache_readonly


You can do the public import here. But, you will also have to try the older import paths.

The hashing imports also can use an update I think

xref pandas-dev#13634 CLN: move pandas.util.* validators, depr_module, decorators, print_versions to _ leading

TomAugspurger · 2017-05-04T11:46:45Z

pandas/tools/hashing.py

+            warnings.warn("pandas.tools.hashing is deprecated and will be "
+                          "removed in a future version, import "
+                          "from pandas.util",
+                          FutureWarning, stacklevel=3)


Thoughts on making this one a DeprecationWarning? The only reason I ask is that dask did a release yesterday. Could do a point release fixing this if needed though.

hmm, sure could do that.

codecov · 2017-05-04T12:03:14Z

Codecov Report

Merging #16223 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #16223      +/-   ##
==========================================
- Coverage   90.25%   90.24%   -0.02%     
==========================================
  Files         162      164       +2     
  Lines       50879    50894      +15     
==========================================
+ Hits        45922    45927       +5     
- Misses       4957     4967      +10

Flag	Coverage Δ
#multiple	`88.02% <100%> (ø)`	⬆️
#single	`40.3% <77.35%> (-0.12%)`	⬇️

Impacted Files	Coverage Δ
pandas/util/_validators.py	`93.75% <ø> (ø)`
pandas/io/clipboard/exceptions.py	`71.42% <ø> (ø)`
pandas/util/_decorators.py	`65.3% <ø> (ø)`
pandas/util/_print_versions.py	`15.71% <ø> (ø)`
pandas/io/clipboard/__init__.py	`73.8% <ø> (ø)`
pandas/io/formats/terminal.py	`47.82% <ø> (ø)`
pandas/util/_doctools.py	`0% <ø> (ø)`
pandas/compat/pickle_compat.py	`69.51% <ø> (ø)`	⬆️
pandas/io/clipboard/windows.py	`11.62% <ø> (ø)`
pandas/io/clipboard/clipboard.py	`100% <ø> (ø)`
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f5ecc9...0245cd7. Read the comment docs.

codecov · 2017-05-04T12:03:15Z

Codecov Report

Merging #16223 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #16223      +/-   ##
==========================================
- Coverage   90.25%   90.23%   -0.02%     
==========================================
  Files         162      164       +2     
  Lines       50879    50894      +15     
==========================================
+ Hits        45922    45926       +4     
- Misses       4957     4968      +11

Flag	Coverage Δ
#multiple	`88.02% <100%> (-0.01%)`	⬇️
#single	`40.3% <77.35%> (-0.12%)`	⬇️

Impacted Files	Coverage Δ
pandas/io/clipboard/clipboards.py	`26.58% <ø> (ø)`
pandas/util/_doctools.py	`0% <ø> (ø)`
pandas/util/_decorators.py	`65.3% <ø> (ø)`
pandas/util/_validators.py	`93.75% <ø> (ø)`
pandas/io/clipboard/exceptions.py	`71.42% <ø> (ø)`
pandas/io/clipboard/windows.py	`11.62% <ø> (ø)`
pandas/io/clipboard/clipboard.py	`100% <ø> (ø)`
pandas/util/_print_versions.py	`15.71% <ø> (ø)`
pandas/compat/pickle_compat.py	`69.51% <ø> (ø)`	⬆️
pandas/util/_depr_module.py	`79.06% <ø> (ø)`
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f5ecc9...0245cd7. Read the comment docs.

TomAugspurger · 2017-05-04T12:03:51Z

Will have to update the test too.

…

On Thu, May 4, 2017 at 7:00 AM, Jeff Reback ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pandas/tools/hashing.py <#16223 (comment)>: > @@ -0,0 +1,18 @@ +import warnings +import sys + +m = sys.modules['pandas.tools.hashing'] +for t in ['hash_pandas_object', 'hash_array']: + + def outer(t=t): + + def wrapper(*args, **kwargs): + from pandas import util + warnings.warn("pandas.tools.hashing is deprecated and will be " + "removed in a future version, import " + "from pandas.util", + FutureWarning, stacklevel=3) hmm, sure could do that. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#16223 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIhpO2eai0OmpXj4EK5w3RJSmMOecks5r2b35gaJpZM4NQKIU> .

jreback · 2017-05-04T12:04:06Z

nore that I didn't move pandas.util.testing as I suspect this is heavily used like pandas.core. So will need to do something about that later.

jreback · 2017-05-04T12:04:29Z

Will have to update the test too.

already did

jorisvandenbossche · 2017-05-05T06:40:47Z

Damn, this broke geopandas .. (we were apparently already using cache_readonly from utils.decorators)

And this will also break released version of dask (not master, as you already did a pr for that)

Any chance in doing a quick fix (0.20.1) before sending out the announcement?

jreback · 2017-05-05T09:19:10Z

does this not work with the latest released of dask?

jorisvandenbossche · 2017-05-05T10:18:03Z

Yes, a clean install of pandas and dask currently does not work.

Can we somehow 'hide' the conda packages for a moment? (I hided the release on pypi as there are no wheels yet)

jreback · 2017-05-05T10:44:28Z

we. an tag a post release
i think it's 0.20.0.post i think is valid

also fyi add to the release checklist
pypi upload is very last step (or ok if u immediately hide)
until conda and wheels are there we want to hide

* CLN: make submodules of pandas.util private xref pandas-dev#13634 CLN: move pandas.util.* validators, depr_module, decorators, print_versions to _ leading * CLN: move remaning extensions to _libs * pandas.tools.hashing FutureWarning -> DeprecationWarning

Version 0.20.0 * tag 'v0.20.0': (742 commits) RLS: v0.20.0 DOC: Whatsnew cleanup (pandas-dev#16245) TST: Test CategoricalIndex in test_is_categorical (pandas-dev#16243) TST: xfail some bottleneck on windows (pandas-dev#16240) DOC, TST: Document and Test Functions in dtypes/common.py (pandas-dev#16237) TST: Remove __init__ statements in testing (pandas-dev#16238) DOC: don't include all methods/attributes of IntervalIndex (pandas-dev#16221) PKG: Fix ModuleNotFoundError: No module named 'pandas.formats' (pandas-dev#16239) RLS: v0.20.0rc2 CLN: make submodules of pandas.util private (pandas-dev#16223) MAINT: Remove tm.TestCase from testing (pandas-dev#16225) MAINT: Complete Conversion to Pytest Idiom (pandas-dev#16201) DOC: add whatsnew for 0.21.0 DEPR: correct deprecation message for datetools (pandas-dev#16202) API Change repr name for table schema (pandas-dev#16204) DOC: Remove various warnings from doc build (pandas-dev#16206) DOC: add whatsnew for v0.20.1 BUG: Fixed renaming of falsey names in build_table_schema (pandas-dev#16205) COMPAT: ensure proper extension dtype's don't pickle the cache (pandas-dev#16207) REF: register custom DisplayFormatter for table schema (pandas-dev#16198) ...

Deprecated in v0.20.0 xref pandas-devgh-16223

Deprecated in v0.20.0 xref gh-16223

Deprecated in v0.20.0 xref pandas-devgh-16223

jreback added the Clean label May 4, 2017

jreback added this to the 0.20.0 milestone May 4, 2017

jreback mentioned this pull request May 4, 2017

COMPAT: pandas 0.20.0 dask/dask#2293

Closed

jreback force-pushed the util branch from 7bacc71 to f7f324b Compare May 4, 2017 02:39

jreback mentioned this pull request May 4, 2017

COMPAT: compat with pandas 0.20.0 for movement of pandas.util.hashing dask/dask#2294

Merged

jorisvandenbossche reviewed May 4, 2017

View reviewed changes

jreback force-pushed the util branch from f7f324b to d642a8a Compare May 4, 2017 10:54

jreback added 2 commits May 4, 2017 07:03

CLN: make submodules of pandas.util private

8d7fa0d

xref pandas-dev#13634 CLN: move pandas.util.* validators, depr_module, decorators, print_versions to _ leading

CLN: move remaning extensions to _libs

4239ef5

jreback force-pushed the util branch from d642a8a to 4239ef5 Compare May 4, 2017 11:09

jreback mentioned this pull request May 4, 2017

RLS: 0.20.0 #16049

Closed

TomAugspurger reviewed May 4, 2017

View reviewed changes

TomAugspurger approved these changes May 4, 2017

View reviewed changes

pandas.tools.hashing FutureWarning -> DeprecationWarning

0245cd7

jsexauer mentioned this pull request May 4, 2017

DEPR: Clean up list of deprecations from prior versions #6581

Closed

1 task

jreback mentioned this pull request May 4, 2017

DEPR: pandas.core, pandas.util.testing #16232

Closed

jreback merged commit e99f56e into pandas-dev:master May 4, 2017

gboeing mentioned this pull request May 5, 2017

upgrading to pandas 0.20.0 breaks geopandas 0.2.1 import geopandas/geopandas#443

Closed

gfyoung added a commit to forking-repos/pandas that referenced this pull request Jan 11, 2018

CLN: Remove pandas.util | tools/hashing.py

de2e5d1

Deprecated in v0.20.0 xref pandas-devgh-16223

gfyoung mentioned this pull request Jan 11, 2018

CLN: Remove pandas.util | tools/hashing.py #19181

Merged

jreback mentioned this pull request Jan 11, 2018

DEPR: deprecations log for removed issues #13777

Closed

jreback pushed a commit that referenced this pull request Jan 11, 2018

CLN: Remove pandas.util | tools/hashing.py (#19181)

1954a83

Deprecated in v0.20.0 xref gh-16223

maximveksler pushed a commit to maximveksler/pandas that referenced this pull request Jan 11, 2018

CLN: Remove pandas.util | tools/hashing.py (pandas-dev#19181)

d3aee98

Deprecated in v0.20.0 xref pandas-devgh-16223

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLN: make submodules of pandas.util private #16223

CLN: make submodules of pandas.util private #16223

jreback commented May 4, 2017

jorisvandenbossche left a comment

jorisvandenbossche May 4, 2017

jreback May 4, 2017

jorisvandenbossche May 4, 2017

jreback May 4, 2017

jorisvandenbossche May 4, 2017

jreback May 4, 2017

jorisvandenbossche May 4, 2017

jreback May 4, 2017

TomAugspurger May 4, 2017

jreback May 4, 2017

codecov bot commented May 4, 2017

codecov bot commented May 4, 2017 •

edited

Loading

TomAugspurger commented May 4, 2017 via email

jreback commented May 4, 2017

jreback commented May 4, 2017

jorisvandenbossche commented May 5, 2017

jreback commented May 5, 2017

jorisvandenbossche commented May 5, 2017

jreback commented May 5, 2017

		@@ -1,5 +1,5 @@
		from .pandas_vb_common import *
		from pandas.util.decorators import cache_readonly

CLN: make submodules of pandas.util private #16223

CLN: make submodules of pandas.util private #16223

Conversation

jreback commented May 4, 2017

jorisvandenbossche left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented May 4, 2017

Codecov Report

codecov bot commented May 4, 2017 • edited Loading

Codecov Report

TomAugspurger commented May 4, 2017 via email

jreback commented May 4, 2017

jreback commented May 4, 2017

jorisvandenbossche commented May 5, 2017

jreback commented May 5, 2017

jorisvandenbossche commented May 5, 2017

jreback commented May 5, 2017

codecov bot commented May 4, 2017 •

edited

Loading