-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make get_firstbday, get_lastbday nogil #18512
Conversation
Will run asv in the morning |
Codecov Report
@@ Coverage Diff @@
## master #18512 +/- ##
==========================================
- Coverage 91.35% 91.31% -0.05%
==========================================
Files 163 163
Lines 49796 49796
==========================================
- Hits 45490 45469 -21
- Misses 4306 4327 +21
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18512 +/- ##
==========================================
- Coverage 91.35% 91.31% -0.05%
==========================================
Files 163 163
Lines 49796 49796
==========================================
- Hits 45490 45469 -21
- Misses 4306 4327 +21
Continue to review full report at Codecov.
|
lgtm. make sure we have sufficient m even micro coverage for these routines |
Small asv run, will run a more thorough one next.
|
Sure. Seems like a good time to run coverage for all of _libs |
|
update need to re-run coverage. ignore coverage stats for now. |
Fixed coverage results ("fixed" does not refer to matplotlib issue). Notwithstanding some tinkering to make coverage work with cython, this is at 262e8ff.
|
It looks like it is incorrectly counting a lot of function/method/constant definitions lines as not-covered. In particular in src/inference it is almost all false-positives. |
These are only used in
tslibs.offsets
and in tests, and every use is preceeded by a call tomonthrange
. But becausemonthrange
returns a tuple, it cannot be declarednogil
. This PR removes the call tomonthrange
in favor of the two separate calls that go intomonthrange
(actually only one is needed forget_first_bday
). On the side we get rid of a few unnecessary calls and get to nogil two more cases worth of the apply_index loops.There are more cases coming up for
shift_months
(i.e. more subclasses getting implementations ofapply_index
) and these will benefit from these changes too.git diff upstream/master -u -- "*.py" | flake8 --diff