Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused funcs from _libs #18533

Merged
merged 1 commit into from
Nov 28, 2017
Merged

Conversation

jbrockmendel
Copy link
Member

See coverage report: #18512 (comment)

This just removes a handful of unused functions. LMK if some should be kept around just-in-case.

Not included in the never-used group but worth mentioning: lib.fast_unique, lib.convert_timestamps, and lib.string_array_replace_from_nan_rep are each called exactly once in io.pytables, not covered in tests (io.pytables looks poorly covered, might have had a bunch of skipTests locally)

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@codecov
Copy link

codecov bot commented Nov 28, 2017

Codecov Report

Merging #18533 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18533      +/-   ##
==========================================
- Coverage   91.35%   91.33%   -0.02%     
==========================================
  Files         164      164              
  Lines       49801    49801              
==========================================
- Hits        45494    45485       -9     
- Misses       4307     4316       +9
Flag Coverage Δ
#multiple 89.13% <ø> (ø) ⬆️
#single 40.81% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88ab693...764009c. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Nov 28, 2017

do u have linting settings that show these?
if so they should be put up as well

@jbrockmendel
Copy link
Member Author

do u have linting settings that show these?

You mean show that they are unused? I didn't know linting could do that. No, this is just based on grepping and seeing only the definition.

@jreback
Copy link
Contributor

jreback commented Nov 28, 2017

yes might be a way to do this more automatically

@jbrockmendel
Copy link
Member Author

If you find such a way let me know. Until then, any objection to PRing them manually as I find them?

@jreback jreback added the Clean label Nov 28, 2017
@jreback jreback added this to the 0.22.0 milestone Nov 28, 2017
@jreback jreback merged commit 94f3923 into pandas-dev:master Nov 28, 2017
@jreback
Copy link
Contributor

jreback commented Nov 28, 2017

yeah sometimes things build up. thanks!

@jreback
Copy link
Contributor

jreback commented Nov 28, 2017

Not included in the never-used group but worth mentioning: lib.fast_unique, lib.convert_timestamps, and lib.string_array_replace_from_nan_rep are each called exactly once in io.pytables, not covered in t

yeah these were put in here for lack of a better location. we could add a separate small lib for this to reduce lib.pyx size if it helps.

@jbrockmendel jbrockmendel deleted the remove_unused branch December 8, 2017 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants