Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: ASV remove uncessary selfs and add setups #18575

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

mroeschke
Copy link
Member

@jorisvandenbossche Added setup with #noqa to the other benchmarks I edited and removed uncessesary selfs

@codecov
Copy link

codecov bot commented Nov 30, 2017

Codecov Report

Merging #18575 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18575      +/-   ##
==========================================
- Coverage   91.35%   91.33%   -0.02%     
==========================================
  Files         164      164              
  Lines       49802    49802              
==========================================
- Hits        45496    45487       -9     
- Misses       4306     4315       +9
Flag Coverage Δ
#multiple 89.13% <ø> (ø) ⬆️
#single 40.81% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7627cca...95faeb6. Read the comment docs.

@jorisvandenbossche jorisvandenbossche merged commit a47ad56 into pandas-dev:master Nov 30, 2017
@jorisvandenbossche
Copy link
Member

Thanks!

@jorisvandenbossche jorisvandenbossche added the Benchmark Performance (ASV) benchmarks label Nov 30, 2017
@jorisvandenbossche jorisvandenbossche added this to the 0.22.0 milestone Nov 30, 2017
@mroeschke mroeschke deleted the more_asv_cleans branch November 30, 2017 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Benchmark Performance (ASV) benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants