Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Remove pandas.util | tools/hashing.py #19181

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Jan 11, 2018

Deprecated in v0.20.0

xref #16223

@gfyoung gfyoung added Deprecate Functionality to remove in pandas Clean labels Jan 11, 2018
@codecov
Copy link

codecov bot commented Jan 11, 2018

Codecov Report

Merging #19181 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19181      +/-   ##
==========================================
- Coverage   91.52%   91.51%   -0.01%     
==========================================
  Files         148      147       -1     
  Lines       48778    48767      -11     
==========================================
- Hits        44642    44631      -11     
  Misses       4136     4136
Flag Coverage Δ
#multiple 89.89% <ø> (-0.01%) ⬇️
#single 41.62% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 982e112...de2e5d1. Read the comment docs.

@jreback jreback added this to the 0.23.0 milestone Jan 11, 2018
@jreback jreback merged commit 1954a83 into pandas-dev:master Jan 11, 2018
@jreback
Copy link
Contributor

jreback commented Jan 11, 2018

thanks!

@gfyoung gfyoung deleted the hashing-module-remove branch January 11, 2018 11:40
@jorisvandenbossche
Copy link
Member

This one is probably fine (as it is not a typical user function, and at that time probably only used by dask), but in general I don't think we should already remove deprecations from 0.20.0 -> commented about that in #6581 (comment)

maximveksler pushed a commit to maximveksler/pandas that referenced this pull request Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants