-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove numpy_helper and some unneeded util functions #22469
Conversation
# libindex.get_value_at will end up calling __getitem__, | ||
# so to avoid recursing we need to unwrap `self` so the | ||
# ndarray.__getitem__ implementation is called. | ||
return libindex.get_value_at(np.asarray(self), sp_loc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure this will be unnecessary after #22325.
Codecov Report
@@ Coverage Diff @@
## master #22469 +/- ##
=========================================
Coverage ? 92.04%
=========================================
Files ? 169
Lines ? 50740
Branches ? 0
=========================================
Hits ? 46705
Misses ? 4035
Partials ? 0
Continue to review full report at Codecov.
|
lgtm. any perf impact? |
It tentatively looks like the direct indexing is an improvement.
Master: PR:
Master: PR: |
thanks! |
Follow-up to pandas-devgh-22469. Closes pandas-devgh-22831.
git diff upstream/master -u -- "*.py" | flake8 --diff