Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Drop nonexistent dependency of _libs/parsers #22883

Merged
merged 1 commit into from
Sep 29, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Sep 29, 2018

Title is self-explanatory.

Follow-up to #22469.
Closes #22831.

@gfyoung gfyoung added the Build Library building on various platforms label Sep 29, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Sep 29, 2018
@pep8speaks
Copy link

Hello @gfyoung! Thanks for submitting the PR.

  • There are no PEP8 issues in the file setup.py !

@gfyoung
Copy link
Member Author

gfyoung commented Sep 29, 2018

@jreback @jbrockmendel : Are you able to confirm locally that the rebuild no longer occurs?

@codecov
Copy link

codecov bot commented Sep 29, 2018

Codecov Report

Merging #22883 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #22883   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         169      169           
  Lines       50830    50830           
=======================================
  Hits        46860    46860           
  Misses       3970     3970
Flag Coverage Δ
#multiple 90.6% <ø> (ø) ⬆️
#single 42.37% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e45a6c1...9414b17. Read the comment docs.

@jbrockmendel
Copy link
Member

Yep, that solved it for me locally. Nice catch.

@jbrockmendel jbrockmendel merged commit f771ef6 into pandas-dev:master Sep 29, 2018
@jbrockmendel
Copy link
Member

@gfyoung thanks!

Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants