Fixturize tests/frame/test_api and tests/sparse/frame/test_frame #22738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @h-vetinari! Thanks for submitting the PR.
|
This was referenced Sep 17, 2018
jreback
added
Testing
|
lgtm @TomAugspurger is this going to completely mess up SparseEA refactor? |
|
At a glance, it doesn't look like the merge will be too bad. I'd recommend merging this first. |
|
thanks |
aeltanawy
pushed a commit
to aeltanawy/pandas
that referenced
this pull request
Sep 20, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --difftests/frame/test_apiwas easy enough to fixturize, but I ran into problems because some tests (notably those inSharedWithSparse) are also used intests/sparse/frame/test_frame, and there, the corresponding fixtures were not available. Therefore, this PR fixturizes both modules simultaneously, which also necessitates a newconftest.pyfor the sparse tests.Some more notes:
SparseDataFrameso far, and couldn't find much documentation for (e.g.default_kind), so the names I chose are best effort_check_allwith parametrization, but since fixtures can't be parametrized (see Using fixtures in pytest.mark.parametrize pytest-dev/pytest#349), I had to replace it with direct calls.