-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Fixturize series/test_arithmetic.py #22771
Conversation
Hello @Anjali2019! Thanks for submitting the PR.
|
Your test won't be able to pass as is because Probably best to revert the commit for |
Also (now that I'm trying to update the references in #22550), it seems you've already got a PR for |
OK, I now see that you have separate PRs for those other files as well. But make sure each PR only changes one module. You can Furthermore, I'd recommend to wait until 2-3 of your 6 open PRs manage to go through review, before you open more of them. Chances are you'll get feedback that will be relevant to the future PRs and will save you time-intensive reverting/rebasing/restarting. |
Corrected all PRs |
closing as stale. |
This is in reference to issue #22550