Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fixturize series/test_arithmetic.py #22771

Closed

Conversation

Anjali2019
Copy link
Contributor

This is in reference to issue #22550

@pep8speaks
Copy link

Hello @Anjali2019! Thanks for submitting the PR.

@h-vetinari
Copy link
Contributor

Your test won't be able to pass as is because test_api.py has a class SharedWithSparse, where some tests for SparseSeries inherit the same tests, but then don't have the required fixtures available. I ran into exactly the same problem on the DataFrame-side, see #22738 how I solved it.

Probably best to revert the commit for test_api.py here and open a separate PR for that.

@h-vetinari
Copy link
Contributor

Also (now that I'm trying to update the references in #22550), it seems you've already got a PR for test_analytics.py and test_validate.py. Probably best to revert those here too.

@h-vetinari
Copy link
Contributor

OK, I now see that you have separate PRs for those other files as well. But make sure each PR only changes one module. You can git revert <hash-of-commit> the others.

Furthermore, I'd recommend to wait until 2-3 of your 6 open PRs manage to go through review, before you open more of them. Chances are you'll get feedback that will be relevant to the future PRs and will save you time-intensive reverting/rebasing/restarting.

@Anjali2019
Copy link
Contributor Author

Corrected all PRs

@gfyoung gfyoung added Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite labels Sep 23, 2018
@jreback
Copy link
Contributor

jreback commented Nov 23, 2018

closing as stale.

@jreback jreback closed this Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants