Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG-23224 Fix PR 23237 / Integer NA creation from None #23310

Merged
merged 2 commits into from
Oct 25, 2018

Conversation

JustinZhengBC
Copy link
Contributor

Followup PR to fix an oversight in PR #23237 as discussed in its thread

@pep8speaks
Copy link

Hello @JustinZhengBC! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Oct 24, 2018

Codecov Report

Merging #23310 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23310      +/-   ##
==========================================
+ Coverage   92.22%   92.22%   +<.01%     
==========================================
  Files         169      169              
  Lines       50911    50911              
==========================================
+ Hits        46954    46955       +1     
+ Misses       3957     3956       -1
Flag Coverage Δ
#multiple 90.65% <100%> (ø) ⬆️
#single 42.29% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/arrays/integer.py 95.48% <100%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c26375...e57f699. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Oct 24, 2018

can you add a test

@jreback jreback added Bug Dtype Conversions Unexpected or buggy dtype conversions ExtensionArray Extending pandas with custom dtypes or arrays. labels Oct 24, 2018
@jreback jreback added this to the 0.24.0 milestone Oct 24, 2018
@jreback jreback changed the title BUG-23224 Fix PR 23237 BUG-23224 Fix PR 23237 / Integer NA creation from None Oct 24, 2018
@jreback jreback merged commit a20b097 into pandas-dev:master Oct 25, 2018
@jreback
Copy link
Contributor

jreback commented Oct 25, 2018

thanks @JustinZhengBC

tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants