Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG-23224 Fix PR 23237 / Integer NA creation from None #23310

Merged
merged 2 commits into from
Oct 25, 2018
Merged

BUG-23224 Fix PR 23237 / Integer NA creation from None #23310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e72df80
BUG-23224 Fix PR 23237
JustinZhengBC Oct 24, 2018
e57f699
BUG-23224 add test
JustinZhengBC Oct 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/arrays/integer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def coerce_to_array(values, dtype, mask=None, copy=False):
values = np.array(values, copy=copy)
if is_object_dtype(values):
inferred_type = lib.infer_dtype(values)
if inferred_type is 'mixed' and isna(values).any():
if inferred_type is 'mixed' and isna(values).all():
values = np.empty(len(values))
values.fill(np.nan)
elif inferred_type not in ['floating', 'integer',
Expand Down
3 changes: 2 additions & 1 deletion pandas/tests/arrays/test_integer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,8 @@ def test_integer_array_constructor_copy():
1.0,
pd.date_range('20130101', periods=2),
np.array(['foo']),
[[1, 2], [3, 4]]])
[[1, 2], [3, 4]],
[np.nan, {'a': 1}]])
def test_to_integer_array_error(values):
# error in converting existing arrays to IntegerArrays
with pytest.raises(TypeError):
Expand Down