API: Disallow dtypes w/o frequency when casting #23392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Datetime
|
Hello @gfyoung! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23392 +/- ##
==========================================
- Coverage 92.16% 92.16% -0.01%
==========================================
Files 166 166
Lines 51224 51222 -2
==========================================
- Hits 47212 47208 -4
- Misses 4012 4014 +2
Continue to review full report at Codecov.
|
|
@jbrockmendel can you have a look see. |
|
I remember this now, so this lgtm. |
gfyoung
force-pushed
the
dtype-timestamp-no-freq
branch
from
4e266ab
to
f375219
Compare
Previously deprecated for Series constructor and the `.astype` method. Now being enforced. xref pandas-devgh-15987.
gfyoung
force-pushed
the
dtype-timestamp-no-freq
branch
from
f375219
to
4c0d882
Compare
|
@jreback : Rebased, and all is green. PTAL. |
|
thanks @gfyoung |
|
Small comments aside, LGTM. |
|
@gfyoung if you can follow up with those comments in another PR |
gfyoung
added a commit
to forking-repos/pandas
that referenced
this pull request
Oct 28, 2018
* Use 'unit' instead of 'frequency' * Minor spacing issues in docs
gfyoung
added a commit
that referenced
this pull request
Oct 28, 2018
thoo
added a commit
to thoo/pandas
that referenced
this pull request
Oct 30, 2018
…y_tests * repo_org/master: (52 commits) ENH: Allow rename_axis to specify index and columns arguments (pandas-dev#20046) STY: proposed isort settings [ci skip] [skip ci] [ciskip] [skipci] (pandas-dev#23366) MAINT: Remove extraneous test.parquet file CLN: Follow-up comments to pandas-devgh-23392 (pandas-dev#23401) BUG GH23282 calling min on series of NaT returns NaT (pandas-dev#23289) unpin openpyxl (pandas-dev#23361) REF: collect ops dispatch functions in one place, try to de-duplicate SparseDataFrame methods (pandas-dev#23060) CLN: Remove pandas.tools module (pandas-dev#23376) CLN: Remove some dtype methods from API (pandas-dev#23390) CLN: Cleanup toplevel namespace shims (pandas-dev#23386) DOC: fixup whatsnew note for GH21394 (pandas-dev#23355) Fix import format at pandas/tests/extension directory (pandas-dev#23365) DOC: Remove Series.sortlevel from api.rst (pandas-dev#23395) API: Disallow dtypes w/o frequency when casting (pandas-dev#23392) BUG/TST/REF: Datetimelike Arithmetic Methods (pandas-dev#23215) STYLE: lint add np.nan* funcs to cython_table (pandas-dev#22109) Run Isort on tests/util single PR (pandas-dev#23347) BUG: Fix date_range overflow (pandas-dev#23345) Run Isort on tests/arrays single PR (pandas-dev#23346) ...
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Previously deprecated for Series constructor and the `.astype` method. Now being enforced. xref pandas-devgh-15987.
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
* Use 'unit' instead of 'frequency' * Minor spacing issues in docs Follow-up to pandas-devgh-23392
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Previously deprecated for Series constructor and the `.astype` method. Now being enforced. xref pandas-devgh-15987.
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
* Use 'unit' instead of 'frequency' * Minor spacing issues in docs Follow-up to pandas-devgh-23392
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
Previously deprecated for Series constructor and the `.astype` method. Now being enforced. xref pandas-devgh-15987.
Pingviinituutti
pushed a commit
to Pingviinituutti/pandas
that referenced
this pull request
Feb 28, 2019
* Use 'unit' instead of 'frequency' * Minor spacing issues in docs Follow-up to pandas-devgh-23392
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously deprecated for
Seriesconstructor and the.astypemethod. Now being enforced.xref #15987.