Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Follow-up comments to gh-23392 #23401

Merged
merged 1 commit into from
Oct 28, 2018
Merged

CLN: Follow-up comments to gh-23392 #23401

merged 1 commit into from
Oct 28, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Oct 28, 2018 •
edited
Loading

  • Use 'unit' instead of 'frequency'
  • Minor spacing issues in docs

Follow-up to #23392.

@gfyoung
CLN: Follow-up comments to pandas-devgh-23392
4796ccb 
* Use 'unit' instead of 'frequency'
* Minor spacing issues in docs
@gfyoung gfyoung added Docs Datetime Datetime data dtype Dtype Conversions Unexpected or buggy dtype conversions Error Reporting Incorrect or improved errors from pandas labels Oct 28, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Oct 28, 2018
@pep8speaks
Copy link

Hello @gfyoung! Thanks for submitting the PR.

@gfyoung gfyoung mentioned this pull request Oct 28, 2018
Merged
@codecov
Copy link

codecov bot commented Oct 28, 2018 •
edited
Loading

Codecov Report

Merging #23401 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23401   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         161      161           
  Lines       51155    51155           
=======================================
  Hits        47157    47157           
  Misses       3998     3998
Flag Coverage Δ
#multiple 90.61% <100%> (ø) ⬆️
#single 42.24% <50%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/dtypes/cast.py 88.92% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9e2278...4796ccb. Read the comment docs.

jbrockmendel
jbrockmendel approved these changes Oct 28, 2018
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for quick follow-up.

@gfyoung
Copy link
Member Author

gfyoung commented Oct 28, 2018

@jbrockmendel is satisfied that the changes address his concerns, so merging.

@gfyoung gfyoung merged commit 96d321c into pandas-dev:master Oct 28, 2018
@gfyoung gfyoung deleted the dtype-timestamp-no-freq-followup branch October 28, 2018 23:57
gfyoung added a commit to forking-repos/pandas that referenced this pull request Oct 29, 2018
@gfyoung
MAINT: Remove extraneous test.parquet file
184bcd3 
Somehow showed up in pandas-devgh-23401 from local doc build.
thoo added a commit to thoo/pandas that referenced this pull request Oct 30, 2018
@thoo
Merge remote-tracking branch 'repo_org/master' into Add_ExtensionArra…
3760dce 
…y_tests

* repo_org/master: (52 commits)
  ENH: Allow rename_axis to specify index and columns arguments  (pandas-dev#20046)
  STY: proposed isort settings [ci skip] [skip ci] [ciskip] [skipci] (pandas-dev#23366)
  MAINT: Remove extraneous test.parquet file
  CLN: Follow-up comments to pandas-devgh-23392 (pandas-dev#23401)
  BUG GH23282 calling min on series of NaT returns NaT (pandas-dev#23289)
  unpin openpyxl (pandas-dev#23361)
  REF: collect ops dispatch functions in one place, try to de-duplicate SparseDataFrame methods (pandas-dev#23060)
  CLN: Remove pandas.tools module (pandas-dev#23376)
  CLN: Remove some dtype methods from API (pandas-dev#23390)
  CLN: Cleanup toplevel namespace shims (pandas-dev#23386)
  DOC: fixup whatsnew note for GH21394 (pandas-dev#23355)
  Fix import format at pandas/tests/extension directory (pandas-dev#23365)
  DOC: Remove Series.sortlevel from api.rst (pandas-dev#23395)
  API: Disallow dtypes w/o frequency when casting (pandas-dev#23392)
  BUG/TST/REF: Datetimelike Arithmetic Methods (pandas-dev#23215)
  STYLE: lint
  add np.nan* funcs to cython_table (pandas-dev#22109)
  Run Isort on tests/util single PR (pandas-dev#23347)
  BUG: Fix date_range overflow (pandas-dev#23345)
  Run Isort on tests/arrays single PR (pandas-dev#23346)
  ...
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@gfyoung @tm9k1
CLN: Follow-up comments to pandas-devgh-23392 (pandas-dev#23401)
f451aad 
* Use 'unit' instead of 'frequency'
* Minor spacing issues in docs

Follow-up to pandas-devgh-23392
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@gfyoung @tm9k1
MAINT: Remove extraneous test.parquet file
c51cbda 
Somehow showed up in pandas-devgh-23401 from local doc build.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
CLN: Follow-up comments to pandas-devgh-23392 (pandas-dev#23401)
8eab8cc 
* Use 'unit' instead of 'frequency'
* Minor spacing issues in docs

Follow-up to pandas-devgh-23392
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
MAINT: Remove extraneous test.parquet file
f937468 
Somehow showed up in pandas-devgh-23401 from local doc build.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
CLN: Follow-up comments to pandas-devgh-23392 (pandas-dev#23401)
3abdc28 
* Use 'unit' instead of 'frequency'
* Minor spacing issues in docs

Follow-up to pandas-devgh-23392
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
MAINT: Remove extraneous test.parquet file
8c38016 
Somehow showed up in pandas-devgh-23401 from local doc build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

@jreback jreback Awaiting requested review from jreback

Assignees
No one assigned
Labels
Datetime Datetime data dtype Docs Dtype Conversions Unexpected or buggy dtype conversions Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gfyoung @pep8speaks @jbrockmendel