-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Validate space before colon docstring parameters #23483 #23506
DOC: Validate space before colon docstring parameters #23483 #23506
Conversation
Hello @dannyhyunkim! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23506 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 161 161
Lines 51318 51318
=======================================
Hits 47339 47339
Misses 3979 3979
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@WillAyd can you take a look and merge if you're happy?
@dannyhyunkim sorry this wasn't merged earlier. Can you please resolve the conflicts? |
@datapythonista I've had a go at resolving conflicts. Could you take a look? Also, how do I rerun the builds/tests? |
@dannyhyunkim, sorry about that, but seems like the CI failed with errors unrelated to your PR. Do you mind merging master into it again, so we trigger a new CI build? |
@datapythonista, done! |
Sorry I missed this before. Great work @dannyhyunkim ! |
* upstream/master: BUG: to_html misses truncation indicators (...) when index=False (pandas-dev#22786) API/DEPR: replace "raise_conflict" with "errors" for df.update (pandas-dev#23657) BUG: Append DataFrame to Series with dateutil timezone (pandas-dev#23685) CLN/CI: Catch that stderr-warning! (pandas-dev#23706) ENH: Allow for join between two multi-index dataframe instances (pandas-dev#20356) Ensure Index._data is an ndarray (pandas-dev#23628) DOC: flake8-per-pr for windows users (pandas-dev#23707) DOC: Handle exceptions when computing contributors. (pandas-dev#23714) DOC: Validate space before colon docstring parameters pandas-dev#23483 (pandas-dev#23506) BUG-22984 Fix truncation of DataFrame representations (pandas-dev#22987)
git diff upstream/master -u -- "*.py" | flake8 --diff