Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Validate space before colon docstring parameters #23483 #23506

Merged
merged 2 commits into from
Nov 15, 2018
Merged

DOC: Validate space before colon docstring parameters #23483 #23506

merged 2 commits into from
Nov 15, 2018

Conversation

dannyhyunkim
Copy link
Contributor

@dannyhyunkim dannyhyunkim commented Nov 5, 2018

@pep8speaks
Copy link

Hello @dannyhyunkim! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

Merging #23506 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23506   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files         161      161           
  Lines       51318    51318           
=======================================
  Hits        47339    47339           
  Misses       3979     3979
Flag Coverage Δ
#multiple 90.63% <ø> (ø) ⬆️
#single 42.31% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a197837...4253b97. Read the comment docs.

@datapythonista datapythonista added Docs CI Continuous Integration Code Style Code style, linting, code_checks labels Nov 5, 2018
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd can you take a look and merge if you're happy?

@jreback jreback added this to the 0.24.0 milestone Nov 6, 2018
@datapythonista
Copy link
Member

@dannyhyunkim sorry this wasn't merged earlier. Can you please resolve the conflicts?

@dannyhyunkim
Copy link
Contributor Author

@datapythonista I've had a go at resolving conflicts. Could you take a look? Also, how do I rerun the builds/tests?

@datapythonista
Copy link
Member

@dannyhyunkim, sorry about that, but seems like the CI failed with errors unrelated to your PR. Do you mind merging master into it again, so we trigger a new CI build?

@dannyhyunkim
Copy link
Contributor Author

@datapythonista, done!

@WillAyd WillAyd merged commit c55057f into pandas-dev:master Nov 15, 2018
@WillAyd
Copy link
Member

WillAyd commented Nov 15, 2018

Sorry I missed this before. Great work @dannyhyunkim !

@dannyhyunkim dannyhyunkim deleted the docstring-parameter-validation branch November 15, 2018 08:48
thoo added a commit to thoo/pandas that referenced this pull request Nov 15, 2018
* upstream/master:
  BUG: to_html misses truncation indicators (...) when index=False (pandas-dev#22786)
  API/DEPR: replace "raise_conflict" with "errors" for df.update (pandas-dev#23657)
  BUG: Append DataFrame to Series with dateutil timezone (pandas-dev#23685)
  CLN/CI: Catch that stderr-warning! (pandas-dev#23706)
  ENH: Allow for join between two multi-index dataframe instances (pandas-dev#20356)
  Ensure Index._data is an ndarray (pandas-dev#23628)
  DOC: flake8-per-pr for windows users (pandas-dev#23707)
  DOC: Handle exceptions when computing contributors. (pandas-dev#23714)
  DOC: Validate space before colon docstring parameters pandas-dev#23483 (pandas-dev#23506)
  BUG-22984 Fix truncation of DataFrame representations (pandas-dev#22987)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Code Style Code style, linting, code_checks Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Validate space before colon in the parameters section of the docstrings
5 participants