-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN/CI: Catch that stderr-warning! #23706
Conversation
Hello @h-vetinari! Thanks for submitting the PR.
|
lgtm. ping on green. thanks for tracking down! |
Codecov Report
@@ Coverage Diff @@
## master #23706 +/- ##
=========================================
Coverage ? 92.24%
=========================================
Files ? 161
Lines ? 51339
Branches ? 0
=========================================
Hits ? 47360
Misses ? 3979
Partials ? 0
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #23706 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 161 161
Lines 51339 51339
=======================================
Hits 47360 47360
Misses 3979 3979
Continue to review full report at Codecov.
|
I'll take your word for it that this catches that warning; big props for getting rid of that annoying thing. |
Could you retrigger that timed-out travis job please? ;-) |
thanks |
* upstream/master: BUG: to_html misses truncation indicators (...) when index=False (pandas-dev#22786) API/DEPR: replace "raise_conflict" with "errors" for df.update (pandas-dev#23657) BUG: Append DataFrame to Series with dateutil timezone (pandas-dev#23685) CLN/CI: Catch that stderr-warning! (pandas-dev#23706) ENH: Allow for join between two multi-index dataframe instances (pandas-dev#20356) Ensure Index._data is an ndarray (pandas-dev#23628) DOC: flake8-per-pr for windows users (pandas-dev#23707) DOC: Handle exceptions when computing contributors. (pandas-dev#23714) DOC: Validate space before colon docstring parameters pandas-dev#23483 (pandas-dev#23506) BUG-22984 Fix truncation of DataFrame representations (pandas-dev#22987)
git diff upstream/master -u -- "*.py" | flake8 --diff
There's an uncaught warning to stderr that bubbles up occasionally without failing the build (as far as I can tell), but it was one of the headfakes on the hunt for the ResourceWarnings in #23680.
There's a long list of failing travis builds in that PR (plus in #22225, #23192, #23582), which also suffer from the warning that this PR fixes, which bubbles up at unpredictable times and looks something like this in the output: