Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN/CI: Catch that stderr-warning! #23706

Merged
merged 3 commits into from
Nov 15, 2018

Conversation

h-vetinari
Copy link
Contributor

There's an uncaught warning to stderr that bubbles up occasionally without failing the build (as far as I can tell), but it was one of the headfakes on the hunt for the ResourceWarnings in #23680.

There's a long list of failing travis builds in that PR (plus in #22225, #23192, #23582), which also suffer from the warning that this PR fixes, which bubbles up at unpredictable times and looks something like this in the output:

..............................................................x...........................................................s....
........................................Skipping line 3: Expected 3 fields in line 3, saw 4
.......................................s.......................................................................................

@pep8speaks
Copy link

Hello @h-vetinari! Thanks for submitting the PR.

@jreback jreback added Testing pandas testing functions or related to the test suite IO CSV read_csv, to_csv labels Nov 14, 2018
@jreback jreback added this to the 0.24.0 milestone Nov 14, 2018
@jreback
Copy link
Contributor

jreback commented Nov 14, 2018

lgtm. ping on green. thanks for tracking down!

@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@e413c49). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #23706   +/-   ##
=========================================
  Coverage          ?   92.24%           
=========================================
  Files             ?      161           
  Lines             ?    51339           
  Branches          ?        0           
=========================================
  Hits              ?    47360           
  Misses            ?     3979           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.64% <ø> (?)
#single 42.34% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e413c49...b097f83. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #23706 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23706   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files         161      161           
  Lines       51339    51339           
=======================================
  Hits        47360    47360           
  Misses       3979     3979
Flag Coverage Δ
#multiple 90.64% <ø> (ø) ⬆️
#single 42.34% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/series.py 93.68% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e413c49...ac5288c. Read the comment docs.

@jbrockmendel
Copy link
Member

I'll take your word for it that this catches that warning; big props for getting rid of that annoying thing.

@h-vetinari
Copy link
Contributor Author

@gfyoung

@h-vetinari : FYI, instead of pushing commits to trigger entirely new builds, just ping one of us. We can restart individual builds for you.

Could you retrigger that timed-out travis job please? ;-)

@jreback jreback merged commit e3e59bf into pandas-dev:master Nov 15, 2018
@jreback
Copy link
Contributor

jreback commented Nov 15, 2018

thanks

thoo added a commit to thoo/pandas that referenced this pull request Nov 15, 2018
* upstream/master:
  BUG: to_html misses truncation indicators (...) when index=False (pandas-dev#22786)
  API/DEPR: replace "raise_conflict" with "errors" for df.update (pandas-dev#23657)
  BUG: Append DataFrame to Series with dateutil timezone (pandas-dev#23685)
  CLN/CI: Catch that stderr-warning! (pandas-dev#23706)
  ENH: Allow for join between two multi-index dataframe instances (pandas-dev#20356)
  Ensure Index._data is an ndarray (pandas-dev#23628)
  DOC: flake8-per-pr for windows users (pandas-dev#23707)
  DOC: Handle exceptions when computing contributors. (pandas-dev#23714)
  DOC: Validate space before colon docstring parameters pandas-dev#23483 (pandas-dev#23506)
  BUG-22984 Fix truncation of DataFrame representations (pandas-dev#22987)
@h-vetinari h-vetinari deleted the catch_stderr_warning branch November 15, 2018 19:01
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO CSV read_csv, to_csv Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants