Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF/TST: Add more pytest idiom to parsers tests #23761

Merged
merged 1 commit into from
Nov 18, 2018
Merged

REF/TST: Add more pytest idiom to parsers tests #23761

merged 1 commit into from
Nov 18, 2018

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Nov 18, 2018

Adds more idiom to the following:

  • parser/comment --> parser/test_comment
  • parser/converters --> parser/test_converters
  • parser/compression --> parser/test_compression
  • parser/dialect --> parser/test_dialect

Builds off of #23712.

In the interest of keeping the diff somewhat manageable, I only modified these four (i.e. we can't get rid of test_parsers.py yet), so we're still in this weird intermediary state, but that's fine.

@gfyoung gfyoung added Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite IO CSV read_csv, to_csv labels Nov 18, 2018
@gfyoung gfyoung added this to the 0.24.0 milestone Nov 18, 2018
@pep8speaks
Copy link

Hello @gfyoung! Thanks for submitting the PR.

@gfyoung
REF/TST: Add more pytest idiom to parsers tests
f6d291e 
Adds more idiom to the following:

* parser/comment --> parser/test_comment
* parser/converters --> parser/test_converters
* parser/compression --> parser/test_compression
* parser/dialect --> parser/test_dialect

Builds off of pandas-devgh-23712.
@gfyoung gfyoung force-pushed the pytest-parsers-idiom branch from d2f762b to f6d291e Compare November 18, 2018 03:17
@codecov
Copy link

codecov bot commented Nov 18, 2018 •
edited
Loading

Codecov Report

Merging #23761 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23761   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files         161      161           
  Lines       51408    51408           
=======================================
  Hits        47416    47416           
  Misses       3992     3992
Flag Coverage Δ
#multiple 90.62% <ø> (ø) ⬆️
#single 42.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24bce1a...f6d291e. Read the comment docs.

@WillAyd
Copy link
Member

WillAyd commented Nov 18, 2018

Is this running the same number of tests as before? Might have missed it in another change but not immediately apparent how these are getting run for each of the subclasses.

Totally +1 on the change just want to double check we get the proper execution

@jreback jreback merged commit bb96447 into pandas-dev:master Nov 18, 2018
@jreback
Copy link
Contributor

jreback commented Nov 18, 2018

thanks @gfyoung some minor comments can followup with (or create issues if they are non-trivial).

@gfyoung gfyoung deleted the pytest-parsers-idiom branch November 18, 2018 21:45
@gfyoung
Copy link
Member Author

gfyoung commented Nov 18, 2018

Is this running the same number of tests as before? Might have missed it in another change but not immediately apparent how these are getting run for each of the subclasses.

@WillAyd : All of the tests are intact. You are more than welcome to confirm. 🙂

gfyoung added a commit to forking-repos/pandas that referenced this pull request Nov 19, 2018
@gfyoung
BUG: Don't warn if default conflicts with dialect
90b2a1d 
xref pandas-devgh-23761.
gfyoung added a commit to forking-repos/pandas that referenced this pull request Nov 19, 2018
@gfyoung
BUG: Don't warn if default conflicts with dialect
ab3cd03 
xref pandas-devgh-23761.
@gfyoung gfyoung mentioned this pull request Nov 19, 2018
Merged
jreback pushed a commit that referenced this pull request Nov 19, 2018
@gfyoung @jreback
BUG: Don't warn if default conflicts with dialect (#23775)
2946745 
xref gh-23761.
thoo added a commit to thoo/pandas that referenced this pull request Nov 19, 2018
@thoo
Merge remote-tracking branch 'upstream/master' into io_csv_docstring_…
7732fbd 
…fixed

* upstream/master: (46 commits)
  DEPS: bump xlrd min version to 1.0.0 (pandas-dev#23774)
  BUG: Don't warn if default conflicts with dialect (pandas-dev#23775)
  BUG: Fixing memory leaks in read_csv (pandas-dev#23072)
  TST: Extend datetime64 arith tests to array classes, fix several broken cases (pandas-dev#23771)
  STYLE: Specify bare exceptions in pandas/tests (pandas-dev#23370)
  ENH: between_time, at_time accept axis parameter (pandas-dev#21799)
  PERF: Use is_utc check to improve performance of dateutil UTC in DatetimeIndex methods (pandas-dev#23772)
  CLN: io/formats/html.py: refactor (pandas-dev#22726)
  API: Make Categorical.searchsorted returns a scalar when supplied a scalar (pandas-dev#23466)
  TST: Add test case for GH14080 for overflow exception (pandas-dev#23762)
  BUG: Don't extract header names if none specified (pandas-dev#23703)
  BUG: Index.str.partition not nan-safe (pandas-dev#23558) (pandas-dev#23618)
  DEPR: tz_convert in the Timestamp constructor (pandas-dev#23621)
  PERF: Datetime/Timestamp.normalize for timezone naive datetimes (pandas-dev#23634)
  TST: Use new arithmetic fixtures, parametrize many more tests (pandas-dev#23757)
  REF/TST: Add more pytest idiom to parsers tests (pandas-dev#23761)
  DOC: Add ignore-deprecate argument to validate_docstrings.py (pandas-dev#23650)
  ENH: update pandas-gbq to 0.8.0, adds credentials arg (pandas-dev#23662)
  DOC: Improve error message to show correct order (pandas-dev#23652)
  ENH: Improve error message for empty object array (pandas-dev#23718)
  ...
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@gfyoung @tm9k1
REF/TST: Add more pytest idiom to parsers tests (pandas-dev#23761)
ded9685 
Adds more idiom to the following:

* parser/comment --> parser/test_comment
* parser/converters --> parser/test_converters
* parser/compression --> parser/test_compression
* parser/dialect --> parser/test_dialect

Builds off of pandas-devgh-23712.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
REF/TST: Add more pytest idiom to parsers tests (pandas-dev#23761)
dd8d827 
Adds more idiom to the following:

* parser/comment --> parser/test_comment
* parser/converters --> parser/test_converters
* parser/compression --> parser/test_compression
* parser/dialect --> parser/test_dialect

Builds off of pandas-devgh-23712.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
BUG: Don't warn if default conflicts with dialect (pandas-dev#23775)
b5457b9 
xref pandas-devgh-23761.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
REF/TST: Add more pytest idiom to parsers tests (pandas-dev#23761)
9b38c24 
Adds more idiom to the following:

* parser/comment --> parser/test_comment
* parser/converters --> parser/test_converters
* parser/compression --> parser/test_compression
* parser/dialect --> parser/test_dialect

Builds off of pandas-devgh-23712.
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@gfyoung @Pingviinituutti
BUG: Don't warn if default conflicts with dialect (pandas-dev#23775)
4343f81 
xref pandas-devgh-23761.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback left review comments

Assignees
No one assigned
Labels
IO CSV read_csv, to_csv Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gfyoung @pep8speaks @WillAyd @jreback