Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Use new arithmetic fixtures, parametrize many more tests #23757

Merged
merged 21 commits into from
Nov 18, 2018
Merged

TST: Use new arithmetic fixtures, parametrize many more tests #23757

merged 21 commits into from
Nov 18, 2018

Conversation

jbrockmendel
Copy link
Member

Focus is mostly on test_datetime64.py to keep things close to orthogonal.

De-duplicates some tests that are in e.g. both TestFrameArithmetic and TestSeriesArithmetic

@pep8speaks
Copy link

Hello @jbrockmendel! Thanks for submitting the PR.

@jreback jreback added the Testing pandas testing functions or related to the test suite label Nov 17, 2018
@jreback jreback added this to the 0.24.0 milestone Nov 17, 2018
@jreback
Copy link
Contributor

jreback commented Nov 17, 2018

looks fine. lots of tests :-D

@jbrockmendel
Copy link
Member Author

looks fine. lots of tests :-D

Yep, and you better believe we're not done yet. Working on a test_timedelta64 branch for after #23642.

@codecov
Copy link

codecov bot commented Nov 18, 2018 •
edited
Loading

Codecov Report

Merging #23757 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23757      +/-   ##
==========================================
+ Coverage   92.23%   92.24%   +0.01%     
==========================================
  Files         161      161              
  Lines       51408    51408              
==========================================
+ Hits        47416    47422       +6     
+ Misses       3992     3986       -6
Flag Coverage Δ
#multiple 90.63% <ø> (+0.01%) ⬆️
#single 42.3% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/util/testing.py 85.56% <0%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24bce1a...d0ac7f2. Read the comment docs.

@jreback jreback merged commit e6eec3e into pandas-dev:master Nov 18, 2018
@jreback
Copy link
Contributor

jreback commented Nov 18, 2018

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the btests branch November 18, 2018 17:53
thoo added a commit to thoo/pandas that referenced this pull request Nov 19, 2018
@thoo
Merge remote-tracking branch 'upstream/master' into io_csv_docstring_…
7732fbd 
…fixed

* upstream/master: (46 commits)
  DEPS: bump xlrd min version to 1.0.0 (pandas-dev#23774)
  BUG: Don't warn if default conflicts with dialect (pandas-dev#23775)
  BUG: Fixing memory leaks in read_csv (pandas-dev#23072)
  TST: Extend datetime64 arith tests to array classes, fix several broken cases (pandas-dev#23771)
  STYLE: Specify bare exceptions in pandas/tests (pandas-dev#23370)
  ENH: between_time, at_time accept axis parameter (pandas-dev#21799)
  PERF: Use is_utc check to improve performance of dateutil UTC in DatetimeIndex methods (pandas-dev#23772)
  CLN: io/formats/html.py: refactor (pandas-dev#22726)
  API: Make Categorical.searchsorted returns a scalar when supplied a scalar (pandas-dev#23466)
  TST: Add test case for GH14080 for overflow exception (pandas-dev#23762)
  BUG: Don't extract header names if none specified (pandas-dev#23703)
  BUG: Index.str.partition not nan-safe (pandas-dev#23558) (pandas-dev#23618)
  DEPR: tz_convert in the Timestamp constructor (pandas-dev#23621)
  PERF: Datetime/Timestamp.normalize for timezone naive datetimes (pandas-dev#23634)
  TST: Use new arithmetic fixtures, parametrize many more tests (pandas-dev#23757)
  REF/TST: Add more pytest idiom to parsers tests (pandas-dev#23761)
  DOC: Add ignore-deprecate argument to validate_docstrings.py (pandas-dev#23650)
  ENH: update pandas-gbq to 0.8.0, adds credentials arg (pandas-dev#23662)
  DOC: Improve error message to show correct order (pandas-dev#23652)
  ENH: Improve error message for empty object array (pandas-dev#23718)
  ...
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
@jbrockmendel @tm9k1
TST: Use new arithmetic fixtures, parametrize many more tests (pandas…
f46013b 
…-dev#23757)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
TST: Use new arithmetic fixtures, parametrize many more tests (pandas…
7ace0ff 
…-dev#23757)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jbrockmendel @Pingviinituutti
TST: Use new arithmetic fixtures, parametrize many more tests (pandas…
c10c0b8 
…-dev#23757)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @pep8speaks @jreback