Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove calls to DataFrame.consolidate in benchmarks #24080

Merged
merged 1 commit into from
Dec 4, 2018
Merged

remove calls to DataFrame.consolidate in benchmarks #24080

merged 1 commit into from
Dec 4, 2018

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented Dec 3, 2018 •
edited
Loading

The DataFrame.consolidate method has been removed for 0.24 (in #23377), but there are still some calls to it in the asv benchmarks. I had a failure in #23752 because of this, so hereby a fix.

This PR uses the internal _consolidate method instead.

@pep8speaks
Copy link

Hello @topper-123! Thanks for submitting the PR.

@topper-123 topper-123 changed the title remove calls to DataFrame.consolidated in benchmarks remove calls to DataFrame.consolidate in benchmarks Dec 3, 2018
@jreback jreback added Performance Memory or execution speed performance Deprecate Functionality to remove in pandas labels Dec 4, 2018
@jreback jreback added this to the 0.24.0 milestone Dec 4, 2018
@jreback jreback merged commit 940104e into pandas-dev:master Dec 4, 2018
@jreback
Copy link
Contributor

jreback commented Dec 4, 2018

thanks @topper-123

@topper-123 topper-123 mentioned this pull request Dec 4, 2018
Closed
@topper-123 topper-123 deleted the benchmarks_consolidated branch December 9, 2018 18:48
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@topper-123 @Pingviinituutti
remove calls to DataFrame.consolidated (pandas-dev#24080)
bebcbbf
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@topper-123 @Pingviinituutti
remove calls to DataFrame.consolidated (pandas-dev#24080)
894af82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Performance Memory or execution speed performance
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@topper-123 @pep8speaks @jreback