Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add 'conda list' for azure/posix after activate 'pandas-dev' #25377

Closed

Conversation

h-vetinari
Copy link
Contributor

Running into debugging problems in #24984 because conda list is never called after installing the pandas-dev environment.

It seems that this is just missing in azure/posix (I reflected the comment in other locations not least to show where else this is already done).

@gfyoung
Copy link
Member

gfyoung commented Feb 19, 2019

I thought this should show up when you run conda install ? Or do we not do that here?

@gfyoung gfyoung added Build Library building on various platforms CI Continuous Integration labels Feb 19, 2019
@h-vetinari
Copy link
Contributor Author

@gfyoung
Check out an azure posix build, e.g. this line and below, there's nothing after the env is installed.

It is present in the windows-equivalent, see the diff (where I add the comment)

@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #25377 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25377      +/-   ##
==========================================
- Coverage   91.73%   91.73%   -0.01%     
==========================================
  Files         173      173              
  Lines       52838    52838              
==========================================
- Hits        48472    48470       -2     
- Misses       4366     4368       +2
Flag Coverage Δ
#multiple 90.29% <ø> (-0.01%) ⬇️
#single 41.29% <ø> (-0.43%) ⬇️
Impacted Files Coverage Δ
pandas/io/excel/_xlrd.py 91.04% <0%> (-2.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2c7519...a953fd6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #25377 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25377      +/-   ##
==========================================
- Coverage   91.73%   91.73%   -0.01%     
==========================================
  Files         173      173              
  Lines       52838    52838              
==========================================
- Hits        48472    48470       -2     
- Misses       4366     4368       +2
Flag Coverage Δ
#multiple 90.29% <ø> (-0.01%) ⬇️
#single 41.29% <ø> (-0.43%) ⬇️
Impacted Files Coverage Δ
pandas/io/excel/_xlrd.py 91.04% <0%> (-2.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2c7519...a953fd6. Read the comment docs.

@saurav2608
Copy link

@h-vetinari - I have a pending PR #24632 . Can you have a look? The PR unifies env creation script.

@h-vetinari
Copy link
Contributor Author

Closing in favour of #24632.

@h-vetinari h-vetinari closed this Feb 24, 2019
@h-vetinari h-vetinari deleted the azure_posix_conda_list branch February 24, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants