CI: add __init__.py to isort skip list

[simonjayhawkins]

4.3.5 - February 24, 2019 - last Python 2.7 Maintenance Release
This is the final Python 2.x release of isort, and includes the following major changes:

Potentially Interface Breaking:

The -r option for removing imports has been renamed -rm to avoid accidental deletions and confusion with the -rc recursive option.
init.py has been removed from the default ignore list. The default ignore list is now empty - with all items needing to be explicitly ignored....

[codecov]

Codecov Report

Merging #25455 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #25455   +/-   ##
=======================================
  Coverage   91.74%   91.74%           
=======================================
  Files         173      173           
  Lines       52923    52923           
=======================================
  Hits        48554    48554           
  Misses       4369     4369

Flag	Coverage Δ
#multiple	90.31% <ø> (ø)	⬆️
#single	41.73% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa08416...06ef7b4. Read the comment docs.

[codecov]

Codecov Report

Merging #25455 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #25455   +/-   ##
=======================================
  Coverage   91.74%   91.74%           
=======================================
  Files         173      173           
  Lines       52923    52923           
=======================================
  Hits        48554    48554           
  Misses       4369     4369

Flag	Coverage Δ
#multiple	90.31% <ø> (ø)	⬆️
#single	41.73% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa08416...674d42d. Read the comment docs.

[gfyoung]

@simonjayhawkins : Do we have instances in our __init__ files where custom import order matters? I understand maintaining status quo, but I just would like to double check, since that would be the major reason for ignoring isort.

cc @jreback

[jreback]

@simonjayhawkins can you just isort these?

[jreback]

also, I don't see us actually installing isort; it seems we are relying on a version that is on the system somehow? @simonjayhawkins can you add isort to each of the ci/deps files fore the azure builds (I guess can't hurt on the travis ones too); put on the universal section

[jreback]

what i mean is, can you just run isort on these?

[jreback]

o i guess could be a followup

[simonjayhawkins]

running isort on all the __init__.py files gives..

ImportError while loading conftest 'C:\Users\simon\OneDrive\code\pandas-simonjayhawkins\pandas\conftest.py'.
pandas\__init__.py:29: in <module>
    import pandas.arrays
pandas\arrays\__init__.py:6: in <module>
    from pandas.core.arrays import (
pandas\core\arrays\__init__.py:4: in <module>
    from .categorical import Categorical  # noqa
pandas\core\arrays\categorical.py:33: in <module>
    from pandas.core.base import NoNewAttributesMixin, PandasObject, _shared_docs
pandas\core\base.py:27: in <module>
    import pandas.core.nanops as nanops
pandas\core\nanops.py:54: in <module>
    set_use_bottleneck(get_option('compute.use_bottleneck'))
pandas\core\config.py:227: in __call__
    return self.__func__(*args, **kwds)
pandas\core\config.py:97: in _get_option
    key = _get_single_key(pat, silent)
pandas\core\config.py:83: in _get_single_key
    raise OptionError('No such keys(s): {pat!r}'.format(pat=pat))
E   pandas.core.config.OptionError: "No such keys(s): 'compute.use_bottleneck'"

so some work required to do this.

[jreback]

gotcha ok then

[simonjayhawkins]

also i'm on Windows and not able to run isort 4.3.8 because of PyCQA/isort#835, so struggling to make progress on this.

[jreback]

ok, can you post an issue about this

[simonjayhawkins]

do we need a separate issue? #23334 is still open. add to that?

[jreback]

let's add to that one.

[jreback]

ping on green

[jorisvandenbossche]

@meeseeksdev backport to 0.24.x

[jorisvandenbossche]

Asked to backport this to get CI green on 0.24.x.

[jorisvandenbossche]

Another question: @simonjayhawkins why did you add isort to all of the CI environments? Don't we only run it and "Checks_and_doc Job" job?

[simonjayhawkins]

Another question: @simonjayhawkins why did you add isort to all of the CI environments? Don't we only run it and "Checks_and_doc Job" job?

@jorisvandenbossche

see #25455 (comment). I was at the London Python Sprint at the time, CI was failing and I would have been AFK while travelled home so didn't question it. Seemed harmless enough, but feel free to change.