CI: Fix GBQ Tests #30478
CI: Fix GBQ Tests #30478
Conversation
alimcmaster1
added
CI
pandas/tests/io/test_gbq.py
Outdated
| project_id=_get_project_id(), | ||
| credentials=_get_credentials(), | ||
| dialect="standard", | ||
| ) | ||
| assert result["num_rows"][0] == test_size | ||
|
|
||
| @pytest.mark.xfail(reason="Test breaking master") | ||
| @pytest.mark.xfail(reason="Test breaking master", strict=False) |
There was a problem hiding this comment.
try to remove this xfail now
|
I've configured travis to run against my fork with the relevant setup for gbq. (As per the instruction here https://github.com/pandas-dev/pandas/pull/15879/files). GBQ Tests are now running against these changes here: https://travis-ci.org/alimcmaster1/pandas/jobs/629696201?utm_medium=notification&utm_source=email |
| _skip_if_no_project_id() | ||
| _skip_if_no_private_key_path() | ||
|
|
||
| cls.client = _get_client() | ||
| cls.dataset = cls.client.dataset(DATASET_ID + "1") | ||
| dataset_id = "pydata_pandas_bq_testing_py31" |
There was a problem hiding this comment.
hmm, this is different than the previous, is that right?
There was a problem hiding this comment.
Previous is here:
https://github.com/pandas-dev/pandas/pull/30478/files#diff-19467f8af166870b0cd441ab9be7ef7cL21-L24
I kept the dataset_id the same as before
|
These tests are running against my fork here - all green and they don't appear in the skipped test section in logs |
|
thanks @alimcmaster1 |
Thanks @jreback I will keep an eye on travis.. |
|
yes thanks @alimcmaster1 |
…ndexing-1row-df * upstream/master: (333 commits) CI: troubleshoot Web_and_Docs failing (pandas-dev#30534) WARN: Ignore NumbaPerformanceWarning in test suite (pandas-dev#30525) DEPR: camelCase in offsets, get_offset (pandas-dev#30340) PERF: implement scalar ops blockwise (pandas-dev#29853) DEPR: Remove Series.compress (pandas-dev#30514) ENH: Add numba engine for rolling apply (pandas-dev#30151) [ENH] Add to_markdown method (pandas-dev#30350) DEPR: Deprecate pandas.np module (pandas-dev#30386) ENH: Add ignore_index for df.drop_duplicates (pandas-dev#30405) BUG: The setting xrot=0 in DataFrame.hist() doesn't work with by and subplots pandas-dev#30288 (pandas-dev#30491) CI: Fix GBQ Tests (pandas-dev#30478) Bug groupby quantile listlike q and int columns (pandas-dev#30485) ENH: Add ignore_index for df.sort_values and series.sort_values (pandas-dev#30402) TYP: Typing hints in pandas/io/formats/{css,csvs}.py (pandas-dev#30398) BUG: raise on non-hashable Index name, closes pandas-dev#29069 (pandas-dev#30335) Replace "foo!r" to "repr(foo)" syntax pandas-dev#29886 (pandas-dev#30502) BUG: preserve EA dtype in transpose (pandas-dev#30091) BLD: add check to prevent tempita name error, clsoes pandas-dev#28836 (pandas-dev#30498) REF/TST: method-specific files for test_append (pandas-dev#30503) marked unused parameters (pandas-dev#30504) ...
|
cc @alimcmaster1 see for example https://travis-ci.org/pandas-dev/pandas/jobs/631599036 we need a try/except around the close part i think and/or a unique dataset name for each test as we are confliciting |
Aaah. I’ll be able to take a look at this tomorrow eve will revert back on here |
|
thanks @alimcmaster1 |
Believe these test only run on master on travis? So will keep xfail for now
Fixturize as per @jreback comment here.
closes #30470