Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: catch missing cython instead of tempita NameError #30498

Merged
merged 2 commits into from
Dec 27, 2019

Conversation

jbrockmendel
Copy link
Member

I named this branch "bld-misc" in the optimistic hope I could close a bunch of BLD issues, but nope, just this one.

@WillAyd
Copy link
Member

WillAyd commented Dec 27, 2019

Looks good to me. I find the global Cython and CYTHON_INSTALLED variables a little strange, so this definitely helps

Anything in particular you are thinking we need to improve on with this?

@jbrockmendel
Copy link
Member Author

I find the global Cython and CYTHON_INSTALLED variables a little strange

Yah I think you're right that they are redundant. I'd be on board with having just one of them.

@jreback jreback added the Build Library building on various platforms label Dec 27, 2019
@jreback jreback added this to the 1.0 milestone Dec 27, 2019
@jreback
Copy link
Contributor

jreback commented Dec 27, 2019

I find the global Cython and CYTHON_INSTALLED variables a little strange

Yah I think you're right that they are redundant. I'd be on board with having just one of them.

yep agreed

@jreback jreback merged commit 7e6125a into pandas-dev:master Dec 27, 2019
@jbrockmendel jbrockmendel deleted the bld-misc branch December 27, 2019 16:16
keechongtan added a commit to keechongtan/pandas that referenced this pull request Dec 29, 2019
…ndexing-1row-df

* upstream/master: (333 commits)
  CI: troubleshoot Web_and_Docs failing (pandas-dev#30534)
  WARN: Ignore NumbaPerformanceWarning in test suite (pandas-dev#30525)
  DEPR: camelCase in offsets, get_offset (pandas-dev#30340)
  PERF: implement scalar ops blockwise (pandas-dev#29853)
  DEPR: Remove Series.compress (pandas-dev#30514)
  ENH: Add numba engine for rolling apply (pandas-dev#30151)
  [ENH] Add to_markdown method (pandas-dev#30350)
  DEPR: Deprecate pandas.np module (pandas-dev#30386)
  ENH: Add ignore_index for df.drop_duplicates (pandas-dev#30405)
  BUG: The setting xrot=0 in DataFrame.hist() doesn't work with by and subplots pandas-dev#30288 (pandas-dev#30491)
  CI: Fix GBQ Tests (pandas-dev#30478)
  Bug groupby quantile listlike q and int columns (pandas-dev#30485)
  ENH: Add ignore_index for df.sort_values and series.sort_values (pandas-dev#30402)
  TYP: Typing hints in pandas/io/formats/{css,csvs}.py (pandas-dev#30398)
  BUG: raise on non-hashable Index name, closes pandas-dev#29069 (pandas-dev#30335)
  Replace "foo!r" to "repr(foo)" syntax pandas-dev#29886 (pandas-dev#30502)
  BUG: preserve EA dtype in transpose (pandas-dev#30091)
  BLD: add check to prevent tempita name error, clsoes pandas-dev#28836 (pandas-dev#30498)
  REF/TST: method-specific files for test_append (pandas-dev#30503)
  marked unused parameters (pandas-dev#30504)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NameError: name 'tempita' is not defined when building extensions with old cython
3 participants