-
-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: GH30999 TESTING PR do not merge or review #38876
TST: GH30999 TESTING PR do not merge or review #38876
Conversation
2c4e554
to
28f4f11
Compare
…sages in test_sql and test_compat
28f4f11
to
4ef2e57
Compare
Well. The CI succeeded without errors. Did not work as I intended. |
When you run pytest, you should see a message to this effect:
which is curious because I know I have SQLAlchemy installed. So a quick search for "13611" in the test code reveals:
Looks like this entire class is skipped even when SQLAlchemy is installed (there is no check). Uncommenting that line these tests need |
@rhshadrach Yes they fail for me too. That's why I decided to try in the CI pipeline. I don't know where to go from here. I guess the options are:
|
Don't you need to remove the |
Oh right. Thanks. That was a bit dumb of me. |
Setting up the pytest fixture doesn't work in the CI, just like on my dev machine. It looks like #13611 is open to remove most of these tests. I don't know if we want to bring that higher in the priority - I don't feel it's something I am qualified to do. |
There are 3 tests that don't run on my dev machine even with tweaks. They should fail in the CI and I can get the messages from there. So for now this is just a PR designed to run (and fail) the CI pipelines.
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff