CLN: Removed the flavor parameter in DataFrame.to_sql #13611

gfyoung · 2016-07-11T06:56:30Z

Deprecated in 0.14.0, so way, way overdue.

jorisvandenbossche · 2016-07-11T07:27:08Z

@gfyoung We cannot just remove the flavor keyword. It was only deprecated for 'mysql', not for 'sqlite' (wihch is a pitty ..)

gfyoung · 2016-07-11T07:28:37Z

@jorisvandenbossche : But the argument accepts only one value now (sqlite), so why not remove it? Are we planning to add new functionality to it in the future? Judging from the documentation, I did not get that impression, as we seem to be relegating more of the functionality to SQLAlchemy (it doesn't even respect the parameter if SQLAlchemy is available).

jorisvandenbossche · 2016-07-11T07:38:35Z

No, we are certainly not planning that. And in retrospect, it's a pitty that we didn't deprecate the full flavor keyword. But we have to deal with it now. I think we should give a nice error/warning message in case of flavor='sqlite'. So either deprecated that, or 'remove' it but still capture it's usage to display a more informative error message.

gfyoung · 2016-07-11T13:41:38Z

@jorisvandenbossche : How does adding a **kwargs parameter sound? Then we can still accept it and warn about it if the user passes it in.

jorisvandenbossche · 2016-07-11T14:23:15Z

@gfyoung That sounds good!

gfyoung · 2016-07-12T02:26:00Z

@jorisvandenbossche : added *args and **kwargs along with a validation function AND skipped all of the test suite that relied on the flavor="mysql" connection. However, I would like to add a test afterwards to make sure the flavor parameter is properly deprecated without these functions getting abused, but I just want to make sure these initial changes appeal the Travis.

codecov-io · 2016-07-12T07:49:32Z

Current coverage is 84.37%

No coverage report found for master at 4c9ae94.

Powered by Codecov. Last updated by 4c9ae94...74e8975

jorisvandenbossche · 2016-07-12T17:53:09Z

pandas/core/generic.py

-    def to_sql(self, name, con, flavor='sqlite', schema=None, if_exists='fail',
-               index=True, index_label=None, chunksize=None, dtype=None):
+    def to_sql(self, name, con, schema=None, if_exists='fail', index=True,
+               index_label=None, chunksize=None, dtype=None, *args, **kwargs):


I don't think the *args are needed here. If people were using positional kwargs, the current deprecation will not work anyways (as schema will catch the flavor)

Alternative is to keep flavor in the signature, but change it to None, so we can detect when people set it to 'sqlite' themselves. That solves the positional kwarg problem, but of course pollutes the signature a bit.

Argh...good point. I think I'll just remove the '*args' parameter and not pollute the signature.

gfyoung · 2016-07-14T14:57:19Z

@jreback , @jorisvandenbossche : Updated the signatures, and Travis is still giving the green light. Ready to merge if there are no other concerns.

jorisvandenbossche · 2016-07-14T16:50:29Z

@gfyoung yeah, I saw your ping, but I also have other work :-)

I worry a bit about the usage of flavor as positional arg .. We actually used it like at some places in the tests I saw in the diff. But it is difficult to judge whether this is used like that by users (a quick stackoverflow search didn't turn anything up).
It would be the safer option to leave it in the signature I think until we actually remove it.

gfyoung · 2016-07-14T19:25:34Z

Yeah...that is a fair point. Original purpose was to just remove the 'mysql' option, so let me scale this PR back down to that.

jorisvandenbossche · 2016-07-14T20:15:08Z

@gfyoung Yes, but I think it would still be good to deprecated the flavor arg, so we can remove it later on. So if you want to do that, I don't it is a large change from what you have now, it's just adding it back in the signature and replacing the kwarg validator with only the deprecation part of it

gfyoung · 2016-07-15T09:18:59Z

@jorisvandenbossche : Updated the signature and put the flavor parameter back. However, it was tricky to issue warnings because flavor is a keyword with default value as "sqlite" in MOST cases. As we don't want to punish users who don't pass it in, and since it has no effect anymore, I changed the default value for flavor in ALL signatures to None. Travis is happy with this change, so ready to merge if there are no other concerns.

gfyoung · 2016-07-15T16:43:51Z

@jreback, @jorisvandenbossche : rebased and Travis is still happy - ready to merge if there are no other concerns.

jorisvandenbossche · 2016-07-15T21:55:59Z

doc/source/whatsnew/v0.19.0.txt

@@ -492,6 +492,7 @@ Deprecations
 - ``Categorical.reshape`` has been deprecated and will be removed in a subsequent release (:issue:`12882`)
 - ``Series.reshape`` has been deprecated and will be removed in a subsequent release (:issue:`12882`)

+- ``DataFrame.to_sql()`` has deprecated the ``flavor`` parameter (:issue:`13611`)


Can you emphasize that is is a superfluous keyword (so no reason to use it), since sqlite is the only supported connection when not using sqlalchemy?

jorisvandenbossche · 2016-07-15T22:03:34Z

@gfyoung Looks good! (using flavor=None is perfect for detecting if user has specified it themselves) Few minor comments.

gfyoung · 2016-07-16T02:38:51Z

@jorisvandenbossche : made the requested doc changes (no need to run tests, hence the [ci skip], so ready to merge if there are no other concerns.

[ci skip]

gfyoung · 2016-07-19T14:38:56Z

@jorisvandenbossche : any updates on this?

jorisvandenbossche · 2016-07-19T20:30:32Z

Yes, merging! Thanks a lot

gfyoung force-pushed the to-sql-flavor-remove branch from 6397fc0 to 8aff8be Compare July 11, 2016 06:58

jorisvandenbossche added IO SQL to_sql, read_sql, read_sql_query Deprecate Functionality to remove in pandas labels Jul 11, 2016

jorisvandenbossche added this to the 0.19.0 milestone Jul 11, 2016

gfyoung force-pushed the to-sql-flavor-remove branch from 8aff8be to d552781 Compare July 11, 2016 14:04

gfyoung force-pushed the to-sql-flavor-remove branch from d552781 to 1eabcc7 Compare July 12, 2016 02:24

jorisvandenbossche reviewed Jul 12, 2016
View reviewed changes

gfyoung force-pushed the to-sql-flavor-remove branch from 1eabcc7 to a571728 Compare July 13, 2016 05:57

gfyoung force-pushed the to-sql-flavor-remove branch 2 times, most recently from b28152c to 4dd32bb Compare July 15, 2016 08:35

gfyoung mentioned this pull request Jul 15, 2016

DEPR: Clean up list of deprecations from prior versions #6581

Closed

1 task

gfyoung force-pushed the to-sql-flavor-remove branch from 4dd32bb to 74e8975 Compare July 15, 2016 16:03

jorisvandenbossche reviewed Jul 15, 2016
View reviewed changes

gfyoung force-pushed the to-sql-flavor-remove branch from 74e8975 to 50885cc Compare July 16, 2016 02:38

gfyoung force-pushed the to-sql-flavor-remove branch from 50885cc to 267ac79 Compare July 16, 2016 02:39

gfyoung mentioned this pull request Jul 16, 2016

MAINT: Make pandasSQL_builder private #13668

Closed

gfyoung force-pushed the to-sql-flavor-remove branch 4 times, most recently from 573646a to 4562ec4 Compare July 19, 2016 02:11

CLN: Removed the flavor parameter in DataFrame.to_sql

02d05a2

[ci skip]

gfyoung force-pushed the to-sql-flavor-remove branch from 4562ec4 to 02d05a2 Compare July 19, 2016 14:38

jorisvandenbossche merged commit 8acfad3 into pandas-dev:master Jul 19, 2016

gfyoung deleted the to-sql-flavor-remove branch July 20, 2016 00:46

jreback mentioned this pull request Jul 24, 2016

DEPR: deprecations log for removed issues #13777

Closed

rhshadrach mentioned this pull request Jan 1, 2021

TST: GH30999 TESTING PR do not merge or review #38876

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLN: Removed the flavor parameter in DataFrame.to_sql #13611

CLN: Removed the flavor parameter in DataFrame.to_sql #13611

gfyoung commented Jul 11, 2016

jorisvandenbossche commented Jul 11, 2016

gfyoung commented Jul 11, 2016 •

edited

Loading

jorisvandenbossche commented Jul 11, 2016

gfyoung commented Jul 11, 2016

jorisvandenbossche commented Jul 11, 2016

gfyoung commented Jul 12, 2016 •

edited

Loading

codecov-io commented Jul 12, 2016 •

edited

Loading

jorisvandenbossche Jul 12, 2016

jorisvandenbossche Jul 12, 2016

gfyoung Jul 12, 2016

gfyoung commented Jul 14, 2016

jorisvandenbossche commented Jul 14, 2016

gfyoung commented Jul 14, 2016

jorisvandenbossche commented Jul 14, 2016

gfyoung commented Jul 15, 2016 •

edited

Loading

gfyoung commented Jul 15, 2016 •

edited

Loading

jorisvandenbossche Jul 15, 2016

gfyoung Jul 16, 2016

jorisvandenbossche commented Jul 15, 2016

gfyoung commented Jul 16, 2016 •

edited

Loading

gfyoung commented Jul 19, 2016

jorisvandenbossche commented Jul 19, 2016

CLN: Removed the flavor parameter in DataFrame.to_sql #13611

CLN: Removed the flavor parameter in DataFrame.to_sql #13611

Conversation

gfyoung commented Jul 11, 2016

jorisvandenbossche commented Jul 11, 2016

gfyoung commented Jul 11, 2016 • edited Loading

jorisvandenbossche commented Jul 11, 2016

gfyoung commented Jul 11, 2016

jorisvandenbossche commented Jul 11, 2016

gfyoung commented Jul 12, 2016 • edited Loading

codecov-io commented Jul 12, 2016 • edited Loading

Current coverage is 84.37%

jorisvandenbossche Jul 12, 2016

Choose a reason for hiding this comment

jorisvandenbossche Jul 12, 2016

Choose a reason for hiding this comment

gfyoung Jul 12, 2016

Choose a reason for hiding this comment

gfyoung commented Jul 14, 2016

jorisvandenbossche commented Jul 14, 2016

gfyoung commented Jul 14, 2016

jorisvandenbossche commented Jul 14, 2016

gfyoung commented Jul 15, 2016 • edited Loading

gfyoung commented Jul 15, 2016 • edited Loading

jorisvandenbossche Jul 15, 2016

Choose a reason for hiding this comment

gfyoung Jul 16, 2016

Choose a reason for hiding this comment

jorisvandenbossche commented Jul 15, 2016

gfyoung commented Jul 16, 2016 • edited Loading

gfyoung commented Jul 19, 2016

jorisvandenbossche commented Jul 19, 2016

gfyoung commented Jul 11, 2016 •

edited

Loading

gfyoung commented Jul 12, 2016 •

edited

Loading

codecov-io commented Jul 12, 2016 •

edited

Loading

gfyoung commented Jul 15, 2016 •

edited

Loading

gfyoung commented Jul 15, 2016 •

edited

Loading

gfyoung commented Jul 16, 2016 •

edited

Loading