Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: is_categorical_dtype #52527

Merged
merged 9 commits into from
Apr 11, 2023

Conversation

jbrockmendel
Copy link
Member

@mroeschke mroeschke added Categorical Categorical Data Type Deprecate Functionality to remove in pandas labels Apr 10, 2023
@mroeschke mroeschke added this to the 2.1 milestone Apr 11, 2023
@mroeschke mroeschke merged commit 658ac5b into pandas-dev:main Apr 11, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the depr-is_categorical_dtype branch April 11, 2023 19:00
galipremsagar added a commit to rapidsai/cudf that referenced this pull request Oct 12, 2023
This PR deprecates `is_categorical_dtype` to match pandas-dev/pandas#52527 which was introduced in `pandas-2.x`. This PR internalizes the public API since this is a needed utility in our code base.

This PR:
```
= 23835 failed, 5698 passed, 1613 skipped, 288 xfailed, 423 errors in 1976.84s (0:32:56) =
```

On `pandas_2.0_feature_branch`:
```
= 24297 failed, 5115 passed, 1613 skipped, 288 xfailed, 480 errors in 1980.46s (0:33:00) =
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categorical Categorical Data Type Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: is_categorical_dtype returns False for Sparse[category, nan]
2 participants