Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate is_categorical_dtype #14274

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Deprecate is_categorical_dtype #14274

merged 2 commits into from
Oct 12, 2023

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Oct 12, 2023 •
edited
Loading

Description

This PR deprecates is_categorical_dtype to match pandas-dev/pandas#52527 which was introduced in pandas-2.x. This PR internalizes the public API since this is a needed utility in our code base.

This PR:

= 23835 failed, 5698 passed, 1613 skipped, 288 xfailed, 423 errors in 1976.84s (0:32:56) =

On pandas_2.0_feature_branch:

= 24297 failed, 5115 passed, 1613 skipped, 288 xfailed, 480 errors in 1980.46s (0:33:00) =

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels Oct 12, 2023
@galipremsagar galipremsagar self-assigned this Oct 12, 2023
@galipremsagar galipremsagar requested review from a team as code owners October 12, 2023 20:16
@galipremsagar galipremsagar requested review from wence- and charlesbluca and removed request for a team October 12, 2023 20:16
@github-actions github-actions bot added the Python Affects Python cuDF API. label Oct 12, 2023
@galipremsagar galipremsagar mentioned this pull request Oct 12, 2023
Closed
mroeschke
mroeschke approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (in a follow up it might make sense narrowing _is_categorical_dtype to isinstance checks or other specific checks)

@galipremsagar
Copy link
Contributor Author

LGTM (in a follow up it might make sense narrowing _is_categorical_dtype to isinstance checks or other specific checks)

Long term I agree we should try doing that, there are multiple places we still need this utility to carefully handle the "category" cases.

@galipremsagar galipremsagar merged commit ad3ae65 into rapidsai:pandas_2.0_feature_branch Oct 12, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @mroeschke