BUG: boolean/string value in OdsWriter (#54994) #54996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this? I don't fully understand the issue from the changelog alone |
dimastbk
force-pushed
the
issue-54994
branch
from
9dea1cd
to
00bc71f
Compare
|
I added test. Also bug is described in #54994. Hm, test fails on win. I need some time for fixing it. |
dimastbk
force-pushed
the
issue-54994
branch
from
00bc71f
to
d329cb8
Compare
5 tasks
WillAyd
approved these changes
Sep 11, 2023
|
I merged main and removed 3 xfails from tests. |
|
Thanks @dimastbk |
hedeershowk
pushed a commit
to hedeershowk/pandas
that referenced
this pull request
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.