-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor PullRequest Image Building and Testing GitHub Actions CI #118
Conversation
seeing a lot of
Eventually leading to failed conda installs with
This was possibly due to a release of Repo2Docker today, so I'm pinning to the previous version 0.10 to reduce the number of changes https://github.com/jupyter/repo2docker/releases/tag/0.11.0 |
To speed up building I've removed the ML-related images from pangeo-notebook. I'm thinking we keep those in a separate ML-focused notebook #119 |
Came across a failed build due to conda network error:
|
This PR also re-configures the Pull Request GitHub Action workflow to pass the base-notebook image between jobs as an "artifact". This is avoids the need to authenticate with docker hub, which is inconvenient for secrets management - PRs often come from forked repositories, but those workflows DO NOT have access to secrets stored in this repository (https://gh.neting.ccmunity/t5/GitHub-Actions/Make-secrets-available-to-builds-of-forks/td-p/30678/page/2 ).
This pull request supersedes:
#120
#121
#123