Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecation warning for python-dump-source-analysis goal #17597

Closed
tdyas opened this issue Nov 20, 2022 · 3 comments · Fixed by #17603
Closed

deprecation warning for python-dump-source-analysis goal #17597

tdyas opened this issue Nov 20, 2022 · 3 comments · Fixed by #17603
Labels
backend: Python Python backend-related issues bug

Comments

@tdyas
Copy link
Contributor

tdyas commented Nov 20, 2022

Deprecation warning encountered after #17057:

19:51:58.21 [WARN] DEPRECATED: Setting `Goal.environment_behavior=EnvironmentBehavior.UNMIGRATED` for `Goal` `python-dump-source-analysis` is scheduled to be removed in version 2.17.0.dev0.
@tdyas tdyas added bug backend: Python Python backend-related issues labels Nov 20, 2022
@tdyas
Copy link
Contributor Author

tdyas commented Nov 20, 2022

cc @lilatomic @stuhood

@lilatomic
Copy link
Contributor

I don't know much about environments. This goal is just dumping the information from python dependency inference. I think this is similar to the Peek goal, which uses environment_behavior=Goal.EnvironmentBehavior.LOCAL_ONLY. The other dump goals use that, but have a TODO referencing #17129 with the comment "Migrate this".

I can just do the same?

@tdyas
Copy link
Contributor Author

tdyas commented Nov 21, 2022

environment_behavior=Goal.EnvironmentBehavior.LOCAL_ONLY should be fine for now. At the very least, it will remove the deprecation warning.

@lilatomic lilatomic mentioned this issue Nov 21, 2022
Merged
stuhood pushed a commit that referenced this issue Nov 22, 2022
@lilatomic
Specify local environment for python source analysis goal (#17603)
89d686f 
matches the other source analysis goals

fixes #17597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend: Python Python backend-related issues bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

specify local environment for python source analysis goal lilatomic/pants
2 participants
@tdyas @lilatomic