specify local environment for python source analysis goal #17603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matches the other source analysis goals
kaos
approved these changes
Nov 21, 2022
Eric-Arellano
approved these changes
Nov 21, 2022
| @@ -65,6 +65,7 @@ class DumpPythonSourceAnalysisSubsystem(GoalSubsystem): | |||
|
|
|||
| class DumpPythonSourceAnalysis(Goal): | |||
| subsystem_cls = DumpPythonSourceAnalysisSubsystem | |||
| environment_behavior = Goal.EnvironmentBehavior.LOCAL_ONLY # TODO(#17129) — Migrate this. | |||
There was a problem hiding this comment.
No need to migrate. This is right
Suggested change
| environment_behavior = Goal.EnvironmentBehavior.LOCAL_ONLY # TODO(#17129) — Migrate this. | |
| environment_behavior = Goal.EnvironmentBehavior.LOCAL_ONLY |
There was a problem hiding this comment.
oh, we should probably change the other debug goals then?
Eric-Arellano
added
the
category:internal
|
Needs cherry-pick to 2.15, right? That's when we landed the source analysis goal? |
Eric-Arellano
added
category:bugfix
No, it landed after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matches the other source analysis goals
fixes #17597