resources jar is reproducible by default, no need to strip #17036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
somdoron
added
the
category:internal
Eric-Arellano
approved these changes
Sep 28, 2022
| @@ -119,8 +118,6 @@ async def assemble_resources_jar( | |||
| ) | |||
|
|
|||
| output_digest = resources_jar_result.output_digest | |||
| if jvm.reproducible_jars: | |||
There was a problem hiding this comment.
Should the option be deprecated?
There was a problem hiding this comment.
it is still in use for java and scala jars, just not needed anymore for resources jar.
pretty sure it is not related, can you please retrigger it? |
stuhood
approved these changes
Sep 28, 2022
|
can this be cherry picked? |
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Sep 28, 2022
…d#17036) Remove use of the `[jvm].reproducible_jars` option for resources jars, since they are now deterministic by default. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Sep 28, 2022
…d#17036) Remove use of the `[jvm].reproducible_jars` option for resources jars, since they are now deterministic by default. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this both in the CI and locally and it seems the zip operation now yields consistent result and doesn't need the strip jar anymore.