Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resources jar is reproducible by default, no need to strip #17036

Merged
merged 1 commit into from
Sep 28, 2022
Merged

resources jar is reproducible by default, no need to strip #17036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/python/pants/jvm/resources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
FallibleClasspathEntries,
FallibleClasspathEntry,
)
from pants.jvm.strip_jar.strip_jar import StripJarRequest
from pants.jvm.subsystems import JvmSubsystem
from pants.util.logging import LogLevel

Expand Down Expand Up @@ -119,8 +118,6 @@ async def assemble_resources_jar(
)

output_digest = resources_jar_result.output_digest
if jvm.reproducible_jars:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the option be deprecated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is still in use for java and scala jars, just not needed anymore for resources jar.

output_digest = await Get(Digest, StripJarRequest(output_digest, tuple(output_files)))
cpe = ClasspathEntry(output_digest, output_files, [])

merged_cpe_digest = await Get(
Expand Down