Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescue Jar tool source code #17514

Merged
merged 4 commits into from
Nov 10, 2022

Conversation

alonsodomin
Copy link
Contributor

Follow up from #17419. Brings jar-tool Java source code from Pants V1 into Pants V2.

The source code is copied over as is and repackaged into Python's wheel as raw source files that will get compiled at runtime later the first time is needed. Because the source involve two different artifacts, they have been placed under a src/java folder and then a reolcated_files target copies them over into the Python package structure so they can be loaded at runtime from a known location.

[ci skip-build-wheels]
[ci skip-rust]

@alonsodomin alonsodomin added backend: JVM JVM backend-related issues category:internal CI, fixes for not-yet-released features, etc. labels Nov 9, 2022
Copy link
Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

// Licensed under the Apache License, Version 2.0 (see LICENSE).

package org.pantsbuild.tools.jar;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This filename is misspelled... maybe it always was?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, it actually was correctly named in the original branch, just fixed it.

@alonsodomin alonsodomin merged commit 86b9cf8 into pantsbuild:main Nov 10, 2022
@stuhood stuhood mentioned this pull request Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: JVM JVM backend-related issues category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants