Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Develop" #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert "Develop" #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Ruby

on:
push:
branches:
- master

pull_request:

jobs:
build:
runs-on: ubuntu-latest

strategy:
matrix:
ruby:
- 3.0.2

steps:
- uses: actions/checkout@v2
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
- name: Run the default task
run: bundle exec rake
27 changes: 0 additions & 27 deletions .github/workflows/run_rubocop.yml
View file
Open in desktop

This file was deleted.

27 changes: 0 additions & 27 deletions .github/workflows/run_tests.yml
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ Layout/LineLength:
Max: 120

AllCops:
NewCops: enable
TargetRubyVersion: 2.6
Exclude:
- 'vendor/**/*'
Expand Down
7 changes: 2 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
# Chatworkify

![Gem](https://img.shields.io/gem/v/chatworkify?color=%234cc61f&label=Gem%20version&logo=ruby&logoColor=red)
![Gem](https://img.shields.io/gem/dt/chatworkify?color=%2330c754&label=Downloads&logo=rubygems&logoColor=red)
![GitHub Workflow Status](https://img.shields.io/github/workflow/status/rs-phunt/chatworkify/Tests%20%F0%9F%A7%AA?label=Tests&logo=github)
![GitHub Workflow Status](https://img.shields.io/github/workflow/status/rs-phunt/chatworkify/Rubocop%20Lint?label=Rubocop&logo=github)
[![Gem Version](https://badge.fury.io/rb/chatworkify.svg)](https://badge.fury.io/rb/chatworkify)

## Installation

Expand Down Expand Up @@ -33,7 +30,7 @@ Require the gem in your `Capfile`:

- Export to your `bash`: `export CHATWORK_API_TOKEN=xxx`

- Add to `.env` if you're using `dotenv` gem
- Add to `.env` if you're using `config` gem


### Puts `CHATWORK_ROOM_ID` into your ENV or custom in `config/deploy`
Expand Down
2 changes: 1 addition & 1 deletion chatworkify.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
spec.required_ruby_version = '>= 2.6'

# spec.metadata['allowed_push_host'] = 'TODO: Set to your gem server 'https://example.com''
spec.metadata['rubygems_mfa_required'] = 'true'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the rubygems_mfa_required metadata attribute from the gemspec file lowers the security standard for publishing this gem. Multi-Factor Authentication (MFA) is a critical security measure, especially for open-source libraries that could be targeted by malicious actors. Consider reinstating this requirement or providing a clear rationale for its removal to ensure the security of the gem and its users.

spec.metadata['homepage_uri'] = spec.homepage
spec.metadata['source_code_uri'] = 'https://github.com/rs-phunt/chatworkify'
spec.metadata['changelog_uri'] = 'https://github.com/rs-phunt/chatworkify/blob/master/CHANGELOG.md'
Expand Down
Loading