Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace async_trait with native -> impl Future #6657

Closed
mattsse opened this issue Feb 18, 2024 · 1 comment
Closed

Replace async_trait with native -> impl Future #6657

mattsse opened this issue Feb 18, 2024 · 1 comment
Assignees
@abhijeetbhagat
Labels
C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Feb 18, 2024

Describe the feature

we require msrv 1.75, might as well use native async trait

TODO

  • get rid of async_trait usage

this can be done trait by trait

Additional context

No response
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started C-debt Refactor of code section that is hard to understand or maintain labels Feb 18, 2024
@abhijeetbhagat
Copy link
Contributor

@mattsse i can take a crack at this.

This was referenced Feb 23, 2024
Merged
Merged
Merged
Merged
Merged
@mattsse mattsse closed this as completed Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhijeetbhagat abhijeetbhagat

Labels
C-debt Refactor of code section that is hard to understand or maintain D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abhijeetbhagat @mattsse