Replace async trait with ->impl Future #6791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbnerZheng
requested review from
mattsse,
Rjected,
emhane and
gakonst
as code owners
AbnerZheng
commented
Feb 26, 2024
| @@ -5,7 +5,6 @@ use reth_rpc_types::{NodeInfo, PeerInfo}; | |||
| /// Admin namespace rpc interface that gives access to several non-standard RPC methods. | |||
| #[cfg_attr(not(feature = "client"), rpc(server, namespace = "admin"))] | |||
| #[cfg_attr(feature = "client", rpc(server, client, namespace = "admin"))] | |||
| #[async_trait::async_trait] | |||
| pub trait AdminApi { | |||
There was a problem hiding this comment.
#[async_trait::async_trait] is not needed here since the macro rpc already uses #[async_trait::async_trait]
mattsse
approved these changes
Feb 26, 2024
mattsse
added
the
C-debt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6657
Remove
async-traitas dependency from cratetransaction-pool,rpc-api.The remaining usage towards
async-traitare mostly related to rpc server implementation based onjsonrpsee, andjsonrpseeis working on migrating to native async trait.