Replace #[async_trait] with ->imp for traits in rpc_testing_util
#6757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbnerZheng
force-pushed
the
replace-async-trait-in-rpc-testing-util
branch
from
c7280ae
to
7973503
Compare
mattsse
approved these changes
Feb 23, 2024
mattsse
reviewed
Feb 23, 2024
| @@ -46,7 +46,6 @@ pub type TraceFilterResult = | |||
| pub type TraceCallResult = Result<TraceResults, (RpcError, TraceCallRequest)>; | |||
|
|
|||
| /// An extension trait for the Trace API. | |||
| #[async_trait::async_trait] | |||
There was a problem hiding this comment.
can remove this as dependency now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #6657
Replace
#[async_trait]with->impfor traits inrpc_testing_util: DebugApiExt and TraceApiClient.