Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): move optimism behaviour from TransactionSigned into new op type #11348

Closed
wants to merge 26 commits into from
Closed

chore(sdk): move optimism behaviour from TransactionSigned into new op type #11348

wants to merge 26 commits into from

Conversation

emhane
Copy link
Member

@emhane emhane commented Sep 30, 2024

Ref #11253

  • Extracts methods from TransactionSigned which differ in implementation for ethereum and optimism, into new trait SignedTransaction
  • Moves optimism specific logic from TransactionSigned to new type OpTransactionSigned

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library labels Sep 30, 2024
mattsse
mattsse reviewed Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I'm having a hard time following this, especially all the unrelated use changes make this hard to review.

this looks very invasive and likely premature.

imo we should approach this from NodePrimtives pov:

#11240

separating the transaction types already seems premature rn

@emhane emhane mentioned this pull request Oct 1, 2024
Closed
@emhane emhane mentioned this pull request Oct 2, 2024
Merged
@emhane
Copy link
Member Author

emhane commented Oct 2, 2024

closing in favour of #11432 and #11433

@emhane emhane closed this Oct 2, 2024
@emhane emhane mentioned this pull request Oct 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse left review comments

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse