Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): define OpTransactionSigned #11433

Open
wants to merge 3 commits into
base: emhane/signed-tx-trait
Choose a base branch
from
Open

chore(sdk): define OpTransactionSigned #11433

wants to merge 3 commits into from
+355 −2

Conversation

emhane
Copy link
Member

@emhane emhane commented Oct 2, 2024

  • Defines new type OpTransactionSigned
  • Extracts optimism feature gated logic from TransactionSigned impl, into impl SignedTransaction for OpTransactionSigned

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library labels Oct 2, 2024
@emhane emhane changed the base branch from main to emhane/signed-tx-trait October 2, 2024 14:14
@emhane emhane mentioned this pull request Oct 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@emhane