initial test case & fix (#9195)

fix unexpected undefined from bundler
parcel-bundler · Aug 23, 2023 · feae29e · feae29e
1 parent 702033b
commit feae29e
Show file tree

Hide file tree

Showing 9 changed files with 49 additions and 1 deletion.
diff --git a/packages/bundlers/default/src/DefaultBundler.js b/packages/bundlers/default/src/DefaultBundler.js
@@ -960,7 +960,7 @@ function createIdealGraph(
 
     // Create shared bundles for splittable bundles.
     if (reachable.length > config.minBundles) {
-      let sourceBundles = reachable.map(a => nullthrows(bundles.get(a.id)));
+      let sourceBundles = reachable.map(a => nullthrows(bundleRoots.get(a))[0]);
       let key = reachable.map(a => a.id).join(',');
       let bundleId = bundles.get(key);
       let bundle;

diff --git a/packages/core/integration-tests/test/css-modules.js b/packages/core/integration-tests/test/css-modules.js
@@ -547,6 +547,33 @@ describe('css modules', () => {
       },
     ]);
   });
+
+  it('should not fail with many css modules', async function () {
+    let b = await bundle(
+      path.join(__dirname, '/integration/css-modules-bug/src/index.html'),
+    );
+
+    assertBundles(b, [
+      {
+        name: 'index.html',
+        assets: ['index.html'],
+      },
+      {
+        type: 'js',
+        assets: [
+          'button.module.css',
+          'main.js',
+          'main.module.css',
+          'other.module.css',
+        ],
+      },
+      {
+        type: 'css',
+        assets: ['button.module.css', 'main.module.css', 'other.module.css'],
+      },
+    ]);
+  });
+
   // Forked because experimental bundler will not merge bundles of same types if they do not share all their bundlegroups
   it('should handle @import in css modules', async function () {
     let b = await bundle(

diff --git a/packages/core/integration-tests/test/integration/css-modules-bug/package.json b/packages/core/integration-tests/test/integration/css-modules-bug/package.json
@@ -0,0 +1,3 @@
+{
+
+}
diff --git a/packages/core/integration-tests/test/integration/css-modules-bug/src/button.module.css b/packages/core/integration-tests/test/integration/css-modules-bug/src/button.module.css
@@ -0,0 +1,3 @@
+.buttonPrimary {
+  align-self: center;
+}
diff --git a/packages/core/integration-tests/test/integration/css-modules-bug/src/index.html b/packages/core/integration-tests/test/integration/css-modules-bug/src/index.html
@@ -0,0 +1,5 @@
+<!DOCTYPE html>
+
+<html lang="en">
+  <script src="main.js" type="module"></script>
+</html>
diff --git a/packages/core/integration-tests/test/integration/css-modules-bug/src/main.js b/packages/core/integration-tests/test/integration/css-modules-bug/src/main.js
@@ -0,0 +1,4 @@
+import * as main from "./main.module.css";
+import * as other from "./other.module.css";
+
+console.log([main.main, other.other]);
diff --git a/packages/core/integration-tests/test/integration/css-modules-bug/src/main.module.css b/packages/core/integration-tests/test/integration/css-modules-bug/src/main.module.css
@@ -0,0 +1,3 @@
+.main {
+  composes: buttonPrimary from "./button.module.css";
+}
diff --git a/packages/core/integration-tests/test/integration/css-modules-bug/src/other.module.css b/packages/core/integration-tests/test/integration/css-modules-bug/src/other.module.css
@@ -0,0 +1,3 @@
+.other {
+  composes: buttonPrimary from "./button.module.css";
+}
diff --git a/packages/core/integration-tests/test/integration/css-modules-bug/yarn.lock b/packages/core/integration-tests/test/integration/css-modules-bug/yarn.lock