Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected undefined when creating shared bundles #9195

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Conversation

AGawrys
Copy link
Contributor

@AGawrys AGawrys commented Aug 15, 2023

↪️ Pull Request

Aims to fix #9058 , by replacing usage of bundles structure in favor of bundleRoots structure. We should replace all instances of bundles but this will fix the issue for now.

💻 Examples

Test case in issue and in PR

🚨 Test instructions

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@AGawrys AGawrys requested a review from gorakong August 15, 2023 19:23
@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.51s -7.00ms
Cached 257.00ms -5.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/index.b8ae99ba.css 94.00b +0.00b 243.00ms -27.00ms 🚀
dist/modern/index.31cedca9.css 94.00b +0.00b 244.00ms -25.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/index.b8ae99ba.css 94.00b +0.00b 247.00ms -22.00ms 🚀
dist/modern/index.31cedca9.css 94.00b +0.00b 247.00ms -22.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 4.30s +85.00ms
Cached 412.00ms +18.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/PermalinkedComment.3145598b.js 3.94kb +0.00b 358.00ms +27.00ms ⚠️
dist/UserProfile.b37bbaff.js 1.38kb +0.00b 358.00ms +27.00ms ⚠️
dist/NotFound.c08212ea.js 265.00b +0.00b 358.00ms +27.00ms ⚠️
dist/logo.8dd07848.png 244.00b +0.00b 296.00ms +20.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/PermalinkedComment.3145598b.js 3.94kb +0.00b 375.00ms -46.00ms 🚀
dist/UserProfile.b37bbaff.js 1.38kb +0.00b 375.00ms -46.00ms 🚀
dist/NotFound.c08212ea.js 265.00b +0.00b 375.00ms -46.00ms 🚀
dist/logo.8dd07848.png 244.00b +0.00b 320.00ms +26.00ms ⚠️

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 38.97s -438.00ms
Cached 2.24s +78.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/editorView.3f952334.js 619.77kb +0.00b 14.61s -919.00ms 🚀
dist/media-viewer.bc1a2415.js 537.32kb +0.00b 12.64s +2.87s ⚠️
dist/ConfigPanelFieldsLoader.8648eeee.js 306.81kb +0.00b 8.73s -1.05s 🚀
dist/card.3521c96b.js 140.18kb +0.00b 12.31s +2.55s ⚠️
dist/ConfigPanelFieldsLoader.1a016f33.js 82.96kb +0.00b 12.52s -628.00ms 🚀
dist/ElementBrowser.c496dd44.js 62.20kb +0.00b 8.72s -1.06s 🚀
dist/archive.fe044de4.js 60.16kb +0.00b 12.64s +2.87s ⚠️
dist/esm.ce3e12df.js 59.72kb +0.00b 12.31s +2.55s ⚠️
dist/ConfigPanelFieldsLoader.8efb299e.js 15.82kb +0.00b 8.72s -1.05s 🚀
dist/ui.8e1e1200.js 14.49kb +0.00b 8.72s -1.06s 🚀
dist/ConfigPanelFieldsLoader.f78f3b60.js 13.65kb +0.00b 8.72s -1.05s 🚀
dist/pdfRenderer.6335b9a2.js 12.08kb +0.00b 12.52s +2.75s ⚠️
dist/mobile-upload.c687ddb2.js 7.86kb +0.00b 8.72s -1.05s 🚀
dist/mobile-upload.e9eb996a.js 7.86kb +0.00b 12.31s +2.54s ⚠️
dist/ru.aaea8ba6.js 2.81kb +0.00b 8.72s -1.01s 🚀
dist/uk.5d2e97bd.js 2.76kb +0.00b 8.72s -1.05s 🚀
dist/codeViewerRenderer.7d374cd5.js 2.61kb +0.00b 12.64s +2.87s ⚠️
dist/th.df60823c.js 2.60kb +0.00b 8.72s -1.05s 🚀
dist/pl.f089a702.js 2.25kb +0.00b 7.86s +1.13s ⚠️
dist/ja.a9cd0bd6.js 2.09kb +0.00b 7.86s +1.13s ⚠️
dist/vi.3e6d5bcb.js 2.09kb +0.00b 8.72s -1.05s 🚀
dist/pt_BR.1db6fd92.js 2.06kb +0.00b 7.86s +1.13s ⚠️
dist/tr.4de346b9.js 2.03kb +0.00b 8.72s -1.05s 🚀
dist/ko.954590a1.js 1.97kb +0.00b 7.86s +1.13s ⚠️
dist/sv.b893ead3.js 1.97kb +0.00b 8.72s -1.05s 🚀
dist/nb.7f52770f.js 1.96kb +0.00b 7.86s +1.13s ⚠️
dist/nl.fd54481e.js 1.94kb +0.00b 7.86s +1.13s ⚠️
dist/zh_TW.3d130b76.js 1.85kb +0.00b 8.72s -1.05s 🚀
dist/zh.fb21f066.js 1.83kb +0.00b 8.72s -1.05s 🚀
dist/workerHasher.322762e4.js 1.56kb +0.00b 8.72s -1.06s 🚀
dist/workerHasher.8fdadeba.js 1.56kb +0.00b 12.31s +2.54s ⚠️
dist/sk.1a0c584e.js 652.00b +0.00b 8.72s -1.05s 🚀
dist/pt_PT.16308ef8.js 631.00b +0.00b 7.86s +1.13s ⚠️
dist/simpleHasher.0488d56a.js 585.00b +0.00b 8.72s -1.06s 🚀
dist/simpleHasher.180c1d91.js 585.00b +0.00b 12.31s +2.54s ⚠️
dist/ro.ee42c980.js 478.00b +0.00b 8.72s +1.98s ⚠️
dist/index.html 248.00b +0.00b 12.69s +6.80s ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/component-lazy.aeb22f50.js 59.50kb +0.00b 5.83s -884.00ms 🚀
dist/mobile-upload.86840439.js 7.86kb +0.00b 5.48s -274.00ms 🚀
dist/codeViewerRenderer.7d374cd5.js 2.61kb +0.00b 8.73s -4.24s 🚀
dist/workerHasher.e01f8bcf.js 1.56kb +0.00b 5.48s -274.00ms 🚀
dist/simpleHasher.329400f6.js 585.00b +0.00b 5.48s -274.00ms 🚀
dist/ro.ee42c980.js 478.00b +0.00b 6.57s -2.54s 🚀

Three.js ✅

Timings

Description Time Difference
Cold 3.25s +114.00ms
Cached 311.00ms +4.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@AGawrys AGawrys merged commit feae29e into v2 Aug 23, 2023
@AGawrys AGawrys deleted the css-module-bug branch August 23, 2023 18:43
@shepmaster
Copy link

I pulled in the nightly version of Parcel and it seems to build my project, so thank you for the fix!

Should we expect a release containing this fix anytime soon? Is there an established release cadence?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in 2.9.0: @parcel/bundler-default: Got unexpected undefined for CSS modules
4 participants