Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev server serves wrong page when using query parameters without extension #9211

Closed
kixelated opened this issue Aug 23, 2023 · 2 comments · Fixed by #9347
Closed

Dev server serves wrong page when using query parameters without extension #9211

kixelated opened this issue Aug 23, 2023 · 2 comments · Fixed by #9347

Comments

@kixelated
Copy link

kixelated commented Aug 23, 2023

🐛 bug report

The dev server serves the wrong page when both:

  • no extension is provided
  • query parameters are used

🎛 Configuration (.babelrc, package.json, cli command)

{
  	"source": [
		"index.html",
		"publish.html",
	],
}

🤔 Expected Behavior

  • /publish returns publish.html
  • /publish?foo=bar returns pubish.html
  • /publish.html?foo=bar returns publish.html

😯 Current Behavior

  • /publish correctly returns publish.html
  • /publish?foo=bar incorrectly returns index.html
  • /publish.html?foo=bar correctly returns publish.html

💻 Code Sample

Reproducible on this commit.

@mischnic
Copy link
Member

The relevant code:

sendIndex(req: Request, res: Response) {

@tanmoyopenroot
Copy link
Contributor

Hey @mischnic, Taking this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants