FIX[dev-server]: Fix html file matching from URL

[tanmoyopenroot]

Closes #9211

↪️ Pull Request

In this PR we rethink how we server the HTML bundle for a given URL in the dev server.

💻 Examples

We get all the htmlBundleFilePaths and sort them based on /(depth)

Example:
For URL /other and let's say we have sorted htmlBundleFilePaths as ['/other.html', 'other/index.html' ]
So for /other URL should be served with /other.html file.

And if we have sorted htmlBundleFilePaths as ['other/index.html' ]
For /other URL should be served with /other/index.html file.

🚨 Test instructions

Extend the html example(packages/examples/HTML).

Create multiple directories like

Add source and dev command in package.json

  "scripts": {
    "dev": "parcel",
    "demo": "parcel build src/index.html"
  },
  "source": [
		"src/index.html",
		"src/other.html",
		"src/temp/index.html",
		"src/temp/other.html",
                 "src/other/index.html",
		"src/other/other.html"
	],

Run yarn run dev to use the local dev server.

Expected Behavior

• /other?foo=bar correctly returns the content of packages/examples/html/src/other.html
• /other.html?foo=bar correctly returns the content of packages/examples/html/src/other.html
• /other correctly returns the content of packages/examples/html/src/other.html
• /other.html correctly returns the content of packages/examples/html/src/other.html
• /other/other?foo=bar correctly returns packages/examples/html/src/other/other.html
• /other/other correctly returns packages/examples/html/src/other/other.html
• /other/index correctly returns packages/examples/html/src/other/index.html

✔️ PR Todo

• Added/updated unit tests for this change
• Filled out test instructions (In case there aren't any unit tests)
• Included links to related issues/PRs

[tanmoyopenroot]

Hey @mischnic, Need your review of this PR.

[mischnic]

The tests are failing

[mischnic]

Please don't change any existing tests, those are there for a reason and need to pass still.
But of course, add new test cases for the linked issue you're trying to fix.

[tanmoyopenroot]

Please don't change any existing tests, those are there for a reason and need to pass still.

For the above folder 👆 and If we look at this line, We find for /something and expect contains of rootIndex - even though /something does not exists, which looks like wrong maybe??? For that, I wrote a different test in line

The same goes for the others like this

Just wondering if that is the expected behaviour.

[mischnic]

No, the existing tests are correct. For a SPA-style app with client-side routing, unknown routes need to return the index page.

To fix #9211, it might be enough to just remove the ?... part before matching it with the existing logic.

[tanmoyopenroot]

No, the existing tests are correct. For a SPA-style app with client-side routing, unknown routes need to return the index page.

Oh okay. Then I will make the required changes

[tanmoyopenroot]

To fix #9211, it might be enough to just remove the ?... part before matching it with the existing logic.

Added the changes. Thanks for helping me out all the way 😃 .

[tanmoyopenroot]

Integration test is failing in windows environment with both node 20 and node 18

Failed to resolve '@parcel/transformer-js/src/esmodule-helpers.js' from 'D:/a/parcel/parcel/packages/transformers/js/src/JSTransformer.js'

Don't think this is related to my changes.

[mischnic]

Yeah that's fine, you can ignore that. The tests are flakey.

[mischnic]

Looks like previously it only looked at req.url, is there a reason why you added originalUrl?

I remember that we had problems with req.originalUrl in the past if you use the proxy in front of the dev server.

[tanmoyopenroot]

Just wanted to make sure we are using the same pathname everywhere like here.