This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
Fix fetchParity(mainWindow) race condition #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI build passed https://gitlab.parity.io/Parity-JS/shell/-/jobs/92063 |
amaury1093
approved these changes
Jul 17, 2018
amaury1093
added
A8-looksgood
|
@axelchalon Could you create a backport to beta? |
axelchalon
added a commit
that referenced
this pull request
Jul 17, 2018
* Fix fetchParity(mainWindow) race condition * Lint
amaury1093
pushed a commit
that referenced
this pull request
Jul 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
fetchParitywas called withmainWindowas argument but we had no guarantee thatmainWindowwas defined at that time.